Skip to content

Commit 074eb4b

Browse files
committed
chore: Fix import order linting error
I think this is failing because we do not observe a lockfile in the [integration-test project](https://github.com/guardian/cdk/blob/9b9a91bc03f507ba4d688024b4fc8059a617f9d0/integration-test/script/ci#L5-L8). As `eslint-plugin-import`'s version includes `^`, we cannot guarantee what version gets used in CI. We hadn't seen it locally as we don't do a fresh install. If you delete integration-test/node_modules and lint the integration-test project, the error can be seen. Options: - Use pinned versions in the integration-test project (I'm not sure if dependabot works with pinned dependency versions) - Do not lint the integration-test project - Use a lockfile and install @guardian/cdk into the integration-test project with `--no-package-lock` (not sure if this is possible as @guardian/cdk will remain in `package.json`) See: - import-js/eslint-plugin-import#2021 - https://docs.npmjs.com/cli/v6/commands/npm-install#:~:text=--no-package-lock
1 parent 120a0ed commit 074eb4b

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

Diff for: integration-test/src/integration-test-stack.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
1+
import { GuDistributionBucketParameter, GuStack } from "@guardian/cdk/lib/constructs/core";
12
import type { App } from "@aws-cdk/core";
23
import type { GuStackProps } from "@guardian/cdk/lib/constructs/core";
3-
import { GuDistributionBucketParameter, GuStack } from "@guardian/cdk/lib/constructs/core";
44

55
export class IntegrationTestStack extends GuStack {
66
constructor(scope: App, id: string, props: GuStackProps) {

0 commit comments

Comments
 (0)