Skip to content

Commit 8a4d332

Browse files
committed
fix: we were looking for ERROR instead of FAILED for failed ray jobs
1 parent 1350e49 commit 8a4d332

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

guidebooks/ml/ray/run/logs/via-websocat.md

+3-3
Original file line numberDiff line numberDiff line change
@@ -36,16 +36,16 @@ if [ -n "${STREAMCONSUMER_LOGS}" ]; then
3636
echo "TODO" 1>&2
3737
else
3838
jobstatus="$(curl -s ${RAY_ADDRESS}/api/jobs/${JOB_ID} | jq -r .status)"
39-
if [[ "SUCCEEDED" != $jobstatus ]] && [[ "ERROR" != $jobstatus ]]; then
39+
if [[ "SUCCEEDED" != $jobstatus ]] && [[ "FAILED" != $jobstatus ]]; then
4040
echo "Waiting (again) for ray job to finish: ${JOB_ID} $jobstatus" 1>&2
4141
websocat --text --exit-on-eof --no-line ${WS_ADDRESS}/api/jobs/${JOB_ID}/logs/tail $WEBSOCAT_OPTS > /dev/null
4242
jobstatus="$(curl -s ${RAY_ADDRESS}/api/jobs/${JOB_ID} | jq -r .status)"
43-
if [[ "SUCCEEDED" != $jobstatus ]] && [[ "ERROR" != $jobstatus ]]; then
43+
if [[ "SUCCEEDED" != $jobstatus ]] && [[ "FAILED" != $jobstatus ]]; then
4444
echo "Polling for ray job to finish: ${JOB_ID} $jobstatus" 1>&2
4545
while true; do
4646
sleep 1
4747
jobstatus="$(curl -s ${RAY_ADDRESS}/api/jobs/${JOB_ID} | jq -r .status)"
48-
if [[ "SUCCEEDED" = $jobstatus ]] || [[ "ERROR" = $jobstatus ]]; then
48+
if [[ "SUCCEEDED" = $jobstatus ]] || [[ "FAILED" = $jobstatus ]]; then
4949
break
5050
fi
5151
done

0 commit comments

Comments
 (0)