Skip to content

Commit 0858444

Browse files
authored
Merge pull request #106 from phprus/cmake-appleclang
Fixed detection of the AppleClang compiler
2 parents b15977a + 7b6b600 commit 0858444

File tree

2 files changed

+2
-2
lines changed

2 files changed

+2
-2
lines changed

cmake/GhcHelper.cmake

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -48,7 +48,7 @@ macro(AddTestExecutableWithStdCpp cppStd)
4848
target_link_libraries(filesystem_test_cpp${cppStd} ghc_filesystem)
4949
target_compile_options(filesystem_test_cpp${cppStd} PRIVATE
5050
$<$<BOOL:${EMSCRIPTEN}>:-s DISABLE_EXCEPTION_CATCHING=0>
51-
$<$<CXX_COMPILER_ID:Clang>:-Wall -Wextra -Wshadow -Wconversion -Wsign-conversion -Wpedantic -Werror -Wno-error=deprecated-declarations>
51+
$<$<OR:$<CXX_COMPILER_ID:Clang>,$<CXX_COMPILER_ID:AppleClang>>:-Wall -Wextra -Wshadow -Wconversion -Wsign-conversion -Wpedantic -Werror -Wno-error=deprecated-declarations>
5252
$<$<CXX_COMPILER_ID:GNU>:-Wall -Wextra -Wshadow -Wconversion -Wsign-conversion -Wpedantic -Wno-psabi -Werror -Wno-error=deprecated-declarations>
5353
$<$<CXX_COMPILER_ID:MSVC>:/WX /wd4996>)
5454
if(CMAKE_CXX_COMPILER_ID MATCHES MSVC)

test/CMakeLists.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@ else()
1919
target_link_libraries(filesystem_test ghc_filesystem)
2020
target_compile_options(filesystem_test PRIVATE
2121
$<$<BOOL:${EMSCRIPTEN}>:-s DISABLE_EXCEPTION_CATCHING=0>
22-
$<$<CXX_COMPILER_ID:Clang>:-Wall -Wextra -Wshadow -Wconversion -Wsign-conversion -Wpedantic -Werror>
22+
$<$<OR:$<CXX_COMPILER_ID:Clang>,$<CXX_COMPILER_ID:AppleClang>>:-Wall -Wextra -Wshadow -Wconversion -Wsign-conversion -Wpedantic -Werror>
2323
$<$<CXX_COMPILER_ID:GNU>:-Wall -Wextra -Wshadow -Wconversion -Wsign-conversion -Wpedantic -Wno-psabi -Werror>
2424
$<$<CXX_COMPILER_ID:MSVC>:/WX>)
2525
if(CMAKE_CXX_COMPILER_ID MATCHES MSVC)

0 commit comments

Comments
 (0)