eth/gasprice: fix percentile validation in eth_feeHistory (ethereum#28954)

fjl · gzliudan · commit 320d1c705ee8 · 2024-09-23T10:36:36.000+08:00
diff --git a/eth/gasprice/feehistory.go b/eth/gasprice/feehistory.go
@@ -229,8 +229,8 @@ func (oracle *Oracle) FeeHistory(ctx context.Context, blocks uint64, unresolvedL
 		if p < 0 || p > 100 {
 			return common.Big0, nil, nil, nil, fmt.Errorf("%w: %f", errInvalidPercentile, p)
 		}
-		if i > 0 && p < rewardPercentiles[i-1] {
-			return common.Big0, nil, nil, nil, fmt.Errorf("%w: #%d:%f > #%d:%f", errInvalidPercentile, i-1, rewardPercentiles[i-1], i, p)
+		if i > 0 && p <= rewardPercentiles[i-1] {
+			return common.Big0, nil, nil, nil, fmt.Errorf("%w: #%d:%f >= #%d:%f", errInvalidPercentile, i-1, rewardPercentiles[i-1], i, p)
 		}
 	}
 	var (

Original file line number	Diff line number	Diff line change
`@@ -229,8 +229,8 @@ func (oracle *Oracle) FeeHistory(ctx context.Context, blocks uint64, unresolvedL`
`229`	`229`	`if p < 0 \|\| p > 100 {`
`230`	`230`	`return common.Big0, nil, nil, nil, fmt.Errorf("%w: %f", errInvalidPercentile, p)`
`231`	`231`	`}`
`232`		`- if i > 0 && p < rewardPercentiles[i-1] {`
`233`		`- return common.Big0, nil, nil, nil, fmt.Errorf("%w: #%d:%f > #%d:%f", errInvalidPercentile, i-1, rewardPercentiles[i-1], i, p)`
	`232`	`+ if i > 0 && p <= rewardPercentiles[i-1] {`
	`233`	`+ return common.Big0, nil, nil, nil, fmt.Errorf("%w: #%d:%f >= #%d:%f", errInvalidPercentile, i-1, rewardPercentiles[i-1], i, p)`
`234`	`234`	`}`
`235`	`235`	`}`
`236`	`236`	`var (`