Skip to content

Commit 355e880

Browse files
committed
fix: handle error when check is image valid
Signed-off-by: Charlie Hsieh <[email protected]>
1 parent e8e6603 commit 355e880

File tree

1 file changed

+11
-6
lines changed

1 file changed

+11
-6
lines changed

lib/imageRouter/index.js

+11-6
Original file line numberDiff line numberDiff line change
@@ -16,13 +16,18 @@ const response = require('../response')
1616
const imageRouter = module.exports = Router()
1717

1818
function checkImageValid (filepath) {
19-
const buffer = readChunk.sync(filepath, 0, 12)
20-
/** @type {{ ext: string, mime: string } | null} */
21-
const mimetypeFromBuf = imageType(buffer)
22-
const mimeTypeFromExt = mime.lookup(path.extname(filepath))
19+
try {
20+
const buffer = readChunk.sync(filepath, 0, 12)
21+
/** @type {{ ext: string, mime: string } | null} */
22+
const mimetypeFromBuf = imageType(buffer)
23+
const mimeTypeFromExt = mime.lookup(path.extname(filepath))
2324

24-
return mimetypeFromBuf && config.allowedUploadMimeTypes.includes(mimetypeFromBuf.mime) &&
25-
mimeTypeFromExt && config.allowedUploadMimeTypes.includes(mimeTypeFromExt)
25+
return mimetypeFromBuf && config.allowedUploadMimeTypes.includes(mimetypeFromBuf.mime) &&
26+
mimeTypeFromExt && config.allowedUploadMimeTypes.includes(mimeTypeFromExt)
27+
} catch (err) {
28+
logger.error(err)
29+
return false
30+
}
2631
}
2732

2833
// upload image

0 commit comments

Comments
 (0)