Skip to content

Commit 996102d

Browse files
committed
fix for catalogs
Former-commit-id: f12ecb6 Former-commit-id: f610216
1 parent d491fae commit 996102d

File tree

1 file changed

+19
-21
lines changed

1 file changed

+19
-21
lines changed

server.js

+19-21
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,6 @@ var app = express();
2121
var server = require("http").createServer(app);
2222
var compress = require('compression'); // Express compression module
2323
var moment = require('moment'); // Time library http://moment.js
24-
2524
var metadata = require('./metadata.js').metadata;
2625

2726
// Test library
@@ -43,10 +42,10 @@ var argv = require('yargs')
4342
.default
4443
({
4544
'port': 8999,
46-
'catalogs': "TestData",
4745
'catalog': "TestData",
48-
'prefixes': '',
46+
'catalogs': '',
4947
'prefix': '',
48+
'prefixes': '',
5049
'verifier': "http://hapi-server.org/verify"
5150
})
5251
.option('help')
@@ -57,10 +56,10 @@ var argv = require('yargs')
5756
.epilog('For more details, see https://github.com/hapi-server/server-nodejs/blob/master/README.md')
5857
.argv;
5958

60-
var FORCE = argv.force === "true"; // Start server if metadata invalid
59+
var FORCE = argv.force || false; // Start server if metadata invalid
6160
var VERIFIER = argv.verifier;
62-
var CATALOG = argv.catalog || argv.catalogs;
63-
var PREFIX = argv.prefix || argv.prefixes;
61+
var CATALOG = argv.catalogs || argv.catalog;
62+
var PREFIX = argv.prefixes || argv.prefix;
6463
var OPEN = argv.open || false; // Open browser window on start
6564

6665
var CATALOGS = CATALOG.split(",");
@@ -104,26 +103,26 @@ if (CATALOGS.length > 1) {
104103
.toString()
105104
.replace(/__CATALOG_LIST__/, JSON.stringify(CATALOGS));
106105

107-
app.get('/', function (req,res) {res.send(html)})
106+
app.get('/', function (req,res) {res.send(html);});
108107
}
109108

110109
for (var i = 0;i < CATALOGS.length;i++) {
111110
console.log(ds() + clc.green("Initializing http://localhost:" + argv.port + PREFIXES[i] + "/hapi"));
112111
console.log(ds() + "Server can be tested/verified on the command line using");
113112
console.log(ds() + " node verify.js --url 'http://localhost:" + argv.port + PREFIXES[i] + "/hapi'");
114-
console.log(ds() + "Server can be tested/verified on localhost page by starting server using");
115-
console.log(ds() + " node server.js --verifier 'http://localhost:9000/'");
116-
console.log(ds() + "and then starting the verifier server using")
117-
console.log(ds() + " node verify.js --port 9000");
118-
113+
console.log(ds() + "Server can be tested/verified on localhost page using");
114+
console.log(ds() + " node verify.js --port 9000 &");
115+
console.log(ds() + " node server.js "
116+
+ process.argv.slice(2).join(' ')
117+
+ " --verifier 'http://localhost:9000/'");
119118
// Initialize the API
120119
apiInit(CATALOGS[i],PREFIXES[i],i == CATALOGS.length-1);
121120
// Read static JSON files
122121
metadata(CATALOGS[i],HAPIVERSION,FORCE,VERIFIER);
123122
}
124123

125-
// TODO: Can server start before apiInit() and metadata() finished?
126-
// If so, prevent it.
124+
// TODO: Server can start before apiInit() and metadata() finished.
125+
// Use await apiInit() and await metadata()
127126
app.listen(argv.port, function () {
128127
if (CATALOGS.length > 1) {
129128
var url = 'http://localhost:' + argv.port;
@@ -313,17 +312,17 @@ function apiInit(catalog,PREFIX,last) {
313312
})
314313

315314
// The following must always be after last app.get() statement.
316-
// Any requests not matching above patterns will trigger errorHandler() call.
315+
// Any requests not matching above patterns will trigger
316+
// errorHandler() call.
317317
if (last) {
318318
// Fall through
319319
app.get('*', function(req, res) {
320320
if (PREFIXES.length == 1) {
321-
res.send("Invalid URL. See <a href='"+PREFIX+"/hapi'>"+PREFIX+"/hapi</a>");
321+
res.send("Invalid URL. See <a href='"+PREFIX+"/hapi'>"+PREFIX.substr(1)+"/hapi</a>");
322322
} else {
323323
res.send("Invalid URL. See <a href='/'>start page</a>");
324324
}
325325
});
326-
327326
app.use(errorHandler);
328327
}
329328
}
@@ -521,7 +520,6 @@ function data(req,res,catalog,header,include) {
521520
}
522521
}
523522
})
524-
525523
}
526524

527525
function prod(arr) {return arr.reduce(function(a,b){return a*b;})}
@@ -859,9 +857,9 @@ function error(req,res,code,message) {
859857
var errs = {
860858
"1400": {status: 400, "message": "HAPI 1400: user input error"},
861859
"1401": {status: 400, "message": "HAPI 1401: unknown request field"},
862-
"1402": {status: 400, "message": "HAPI 1402: error in start time"},
863-
"1403": {status: 400, "message": "HAPI 1403: error in stop time"},
864-
"1404": {status: 400, "message": "HAPI 1404: start time equal to or after stop time"},
860+
"1402": {status: 400, "message": "HAPI 1402: error in time.min"},
861+
"1403": {status: 400, "message": "HAPI 1403: error in time.min"},
862+
"1404": {status: 400, "message": "HAPI 1404: time.min equal to or after time.max"},
865863
"1405": {status: 400, "message": "HAPI 1405: time outside valid range"},
866864
"1406": {status: 404, "message": "HAPI 1406: unknown dataset id"},
867865
"1407": {status: 404, "message": "HAPI 1407: unknown dataset parameter"},

0 commit comments

Comments
 (0)