Skip to content

Commit 15d0fad

Browse files
committed
Add resultOrdered="true" and change expected cursor's nestedResultObjects size to be less than 3
1 parent d5d83ab commit 15d0fad

File tree

2 files changed

+2
-2
lines changed

2 files changed

+2
-2
lines changed

src/test/java/org/apache/ibatis/submitted/cursor_cache_oom/CursorOomTest.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -103,7 +103,7 @@ void shouldNotCacheAllDataForWholeSessionWhileUsingCursor() throws IOException,
103103
// the most preferrable way will be not to cache data, when the row is already processed (see commented
104104
// line above)
105105
Assertions.assertTrue(
106-
cursorList.isEmpty() || getNestedResultObjects((Cursor<User>) cursorList.get(0)).isEmpty()
106+
cursorList.isEmpty() || getNestedResultObjects((Cursor<User>) cursorList.get(0)).size() <= 2
107107
);
108108
}
109109
}

src/test/resources/org/apache/ibatis/submitted/cursor_cache_oom/Mapper.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@
3030
insert into users values(#{id}, #{name})
3131
</insert>
3232

33-
<select id="fetchUsers" resultMap="User">
33+
<select id="fetchUsers" resultMap="User" resultOrdered="true">
3434
select u.id as id, u.name as name, f.name as friend_name
3535
from users as u
3636
left join users as f on u.friend_id = f.id

0 commit comments

Comments
 (0)