@@ -212,6 +212,8 @@ def test_create_instance(self, tmp_path):
212
212
logger_instance .stop ()
213
213
214
214
def test_should_rollover (self , tmp_path ):
215
+ # NOTE: Move to TestRotatingLogger at v5.0 release when
216
+ # SizedRotatingLogger is removed.
215
217
base_filename = "mylogfile.ASC"
216
218
max_bytes = 512
217
219
@@ -235,6 +237,8 @@ def test_should_rollover(self, tmp_path):
235
237
logger_instance .stop ()
236
238
237
239
def test_logfile_size (self , tmp_path ):
240
+ # NOTE: Move to TestRotatingLogger at v5.0 release when
241
+ # SizedRotatingLogger is removed.
238
242
base_filename = "mylogfile.ASC"
239
243
max_bytes = 1024
240
244
msg = generate_message (0x123 )
@@ -251,6 +255,8 @@ def test_logfile_size(self, tmp_path):
251
255
logger_instance .stop ()
252
256
253
257
def test_logfile_size_context_manager (self , tmp_path ):
258
+ # NOTE: Move to TestRotatingLogger at v5.0 release when
259
+ # SizedRotatingLogger is removed.
254
260
base_filename = "mylogfile.ASC"
255
261
max_bytes = 1024
256
262
msg = generate_message (0x123 )
@@ -291,7 +297,7 @@ def test_create_instance(self, tmp_path):
291
297
292
298
logger_instance .stop ()
293
299
294
- def test_should_rollover (self , tmp_path ):
300
+ def test_should_rollover_time (self , tmp_path ):
295
301
base_filename = "mylogfile.ASC"
296
302
max_seconds = 300
297
303
0 commit comments