Skip to content

Commit 8aff574

Browse files
committed
Add note to preserve size rotating test functions at v5.0
1 parent ad382b5 commit 8aff574

File tree

1 file changed

+7
-1
lines changed

1 file changed

+7
-1
lines changed

test/test_rotating_loggers.py

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -212,6 +212,8 @@ def test_create_instance(self, tmp_path):
212212
logger_instance.stop()
213213

214214
def test_should_rollover(self, tmp_path):
215+
# NOTE: Move to TestRotatingLogger at v5.0 release when
216+
# SizedRotatingLogger is removed.
215217
base_filename = "mylogfile.ASC"
216218
max_bytes = 512
217219

@@ -235,6 +237,8 @@ def test_should_rollover(self, tmp_path):
235237
logger_instance.stop()
236238

237239
def test_logfile_size(self, tmp_path):
240+
# NOTE: Move to TestRotatingLogger at v5.0 release when
241+
# SizedRotatingLogger is removed.
238242
base_filename = "mylogfile.ASC"
239243
max_bytes = 1024
240244
msg = generate_message(0x123)
@@ -251,6 +255,8 @@ def test_logfile_size(self, tmp_path):
251255
logger_instance.stop()
252256

253257
def test_logfile_size_context_manager(self, tmp_path):
258+
# NOTE: Move to TestRotatingLogger at v5.0 release when
259+
# SizedRotatingLogger is removed.
254260
base_filename = "mylogfile.ASC"
255261
max_bytes = 1024
256262
msg = generate_message(0x123)
@@ -291,7 +297,7 @@ def test_create_instance(self, tmp_path):
291297

292298
logger_instance.stop()
293299

294-
def test_should_rollover(self, tmp_path):
300+
def test_should_rollover_time(self, tmp_path):
295301
base_filename = "mylogfile.ASC"
296302
max_seconds = 300
297303

0 commit comments

Comments
 (0)