Skip to content

Commit ae41b3e

Browse files
authored
replace socket.error with OSError (#1373)
1 parent f6d8fe0 commit ae41b3e

File tree

3 files changed

+10
-10
lines changed

3 files changed

+10
-10
lines changed

can/interfaces/socketcan/socketcan.py

+8-8
Original file line numberDiff line numberDiff line change
@@ -530,7 +530,7 @@ def capture_message(
530530
channel = addr[0] if isinstance(addr, tuple) else addr
531531
else:
532532
channel = None
533-
except socket.error as error:
533+
except OSError as error:
534534
raise can.CanOperationError(f"Error receiving: {error.strerror}", error.errno)
535535

536536
can_id, can_dlc, flags, data = dissect_can_frame(cf)
@@ -656,29 +656,29 @@ def __init__(
656656
self.socket.setsockopt(
657657
SOL_CAN_RAW, CAN_RAW_LOOPBACK, 1 if local_loopback else 0
658658
)
659-
except socket.error as error:
659+
except OSError as error:
660660
log.error("Could not set local loopback flag(%s)", error)
661661

662662
# set the receive_own_messages parameter
663663
try:
664664
self.socket.setsockopt(
665665
SOL_CAN_RAW, CAN_RAW_RECV_OWN_MSGS, 1 if receive_own_messages else 0
666666
)
667-
except socket.error as error:
667+
except OSError as error:
668668
log.error("Could not receive own messages (%s)", error)
669669

670670
# enable CAN-FD frames if desired
671671
if fd:
672672
try:
673673
self.socket.setsockopt(SOL_CAN_RAW, CAN_RAW_FD_FRAMES, 1)
674-
except socket.error as error:
674+
except OSError as error:
675675
log.error("Could not enable CAN-FD frames (%s)", error)
676676

677677
if not ignore_rx_error_frames:
678678
# enable error frames
679679
try:
680680
self.socket.setsockopt(SOL_CAN_RAW, CAN_RAW_ERR_FILTER, 0x1FFFFFFF)
681-
except socket.error as error:
681+
except OSError as error:
682682
log.error("Could not enable error frames (%s)", error)
683683

684684
# enable nanosecond resolution timestamping
@@ -714,7 +714,7 @@ def _recv_internal(
714714
# get all sockets that are ready (can be a list with a single value
715715
# being self.socket or an empty list if self.socket is not ready)
716716
ready_receive_sockets, _, _ = select.select([self.socket], [], [], timeout)
717-
except socket.error as error:
717+
except OSError as error:
718718
# something bad happened (e.g. the interface went down)
719719
raise can.CanOperationError(
720720
f"Failed to receive: {error.strerror}", error.errno
@@ -776,7 +776,7 @@ def _send_once(self, data: bytes, channel: Optional[str] = None) -> int:
776776
sent = self.socket.sendto(data, (channel,))
777777
else:
778778
sent = self.socket.send(data)
779-
except socket.error as error:
779+
except OSError as error:
780780
raise can.CanOperationError(
781781
f"Failed to transmit: {error.strerror}", error.errno
782782
)
@@ -840,7 +840,7 @@ def _get_bcm_socket(self, channel: str) -> socket.socket:
840840
def _apply_filters(self, filters: Optional[can.typechecking.CanFilters]) -> None:
841841
try:
842842
self.socket.setsockopt(SOL_CAN_RAW, CAN_RAW_FILTER, pack_filters(filters))
843-
except socket.error as error:
843+
except OSError as error:
844844
# fall back to "software filtering" (= not in kernel)
845845
self._is_filtered = False
846846
log.error(

can/interfaces/socketcand/socketcand.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -93,7 +93,7 @@ def _recv_internal(self, timeout):
9393
ready_receive_sockets, _, _ = select.select(
9494
[self.__socket], [], [], timeout
9595
)
96-
except socket.error as exc:
96+
except OSError as exc:
9797
# something bad happened (e.g. the interface went down)
9898
log.error(f"Failed to receive: {exc}")
9999
raise can.CanError(f"Failed to receive: {exc}")

can/interfaces/udp_multicast/bus.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -332,7 +332,7 @@ def recv(
332332
# get all sockets that are ready (can be a list with a single value
333333
# being self.socket or an empty list if self.socket is not ready)
334334
ready_receive_sockets, _, _ = select.select([self._socket], [], [], timeout)
335-
except socket.error as exc:
335+
except OSError as exc:
336336
# something bad (not a timeout) happened (e.g. the interface went down)
337337
raise can.CanOperationError(
338338
f"Failed to wait for IP/UDP socket: {exc}"

0 commit comments

Comments
 (0)