check argument format

Author: zariiii9003

can/logger.py

@@ -135,6 +135,10 @@ def _parse_filters(parsed_args: Any) -> CanFilters:
 def _parse_additonal_config(
     unknown_args: Sequence[str],
 ) -> Dict[str, Union[str, int, float, bool]]:
+    for arg in unknown_args:
+        if not re.match(r"^--[a-zA-Z\-]*?=\S*?$", arg):
+            raise ValueError(f"Parsing argument {arg} failed")
+
     def _split_arg(_arg: str) -> Tuple[str, str]:
         left, right = _arg.split("=", 1)
         return left.lstrip("--").replace("-", "_"), right

test/test_logger.py

@@ -10,6 +10,9 @@
 import gzip
 import os
 import sys
+
+import pytest
+
 import can
 import can.logger
 
@@ -110,6 +113,7 @@ def test_parse_additonal_config(self):
             "--app-name=CANalyzer",
             "--serial=5555",
             "--receive-own-messages=True",
+            "--false-boolean=False",
             "--offset=1.5",
         ]
         parsed_args = can.logger._parse_additonal_config(unknown_args)
@@ -126,9 +130,27 @@ def test_parse_additonal_config(self):
             and parsed_args["receive_own_messages"] is True
         )
 
+        assert "false_boolean" in parsed_args
+        assert (
+            isinstance(parsed_args["false_boolean"], bool)
+            and parsed_args["false_boolean"] is False
+        )
+
         assert "offset" in parsed_args
         assert parsed_args["offset"] == 1.5
 
+        with pytest.raises(ValueError):
+            can.logger._parse_additonal_config(["--wrong-format"])
+
+        with pytest.raises(ValueError):
+            can.logger._parse_additonal_config(["-wrongformat=value"])
+
+        with pytest.raises(ValueError):
+            can.logger._parse_additonal_config(["--wrongformat=value1 value2"])
+
+        with pytest.raises(ValueError):
+            can.logger._parse_additonal_config(["wrongformat="])
+
 
 class TestLoggerCompressedFile(unittest.TestCase):
     def setUp(self) -> None: