Skip to content

Supporting Tx/Rx message direction for each interface #776

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
5 of 17 tasks
sou1hacker opened this issue Feb 21, 2020 · 3 comments
Open
5 of 17 tasks

Supporting Tx/Rx message direction for each interface #776

sou1hacker opened this issue Feb 21, 2020 · 3 comments

Comments

@sou1hacker
Copy link
Contributor

sou1hacker commented Feb 21, 2020

Pull request #773 adds is_rx attribute to can.Message. Currently this attribute is set to True by default. Functionality needs to be added to each interface type to set this attribute appropriately when building CAN messages:

@bessman
Copy link
Contributor

bessman commented Feb 24, 2020

How should receive_own_messages behave with this change? Should messages transmitted by other applications have is_rx=False?

I'm looking at Kvaser's canlib, and I can see no obvious way to accomplish that.

@tamenol
Copy link
Contributor

tamenol commented Feb 27, 2020

I was looking to implement this for the PCAN bus. However I can't seem to find a variable in the PCANbasic library I could use to check if it's RX or TX. Someone has an idea?

TPCANMessageType only has these values:

# PCAN message types
PCAN_MESSAGE_STANDARD = TPCANMessageType(
    0x00
)  # The PCAN message is a CAN Standard Frame (11-bit identifier)
PCAN_MESSAGE_RTR = TPCANMessageType(
    0x01
)  # The PCAN message is a CAN Remote-Transfer-Request Frame
PCAN_MESSAGE_EXTENDED = TPCANMessageType(
    0x02
)  # The PCAN message is a CAN Extended Frame (29-bit identifier)
PCAN_MESSAGE_FD = TPCANMessageType(
    0x04
)  # The PCAN message represents a FD frame in terms of CiA Specs
PCAN_MESSAGE_BRS = TPCANMessageType(
    0x08
)  # The PCAN message represents a FD bit rate switch (CAN data at a higher bit rate)
PCAN_MESSAGE_ESI = TPCANMessageType(
    0x10
)  # The PCAN message represents a FD error state indicator(CAN FD transmitter was error active)
PCAN_MESSAGE_ERRFRAME = TPCANMessageType(
    0x40
)  # The PCAN message represents an error frame
PCAN_MESSAGE_STATUS = TPCANMessageType(
    0x80
)  # The PCAN message represents a PCAN status message

@chrisoro
Copy link
Contributor

@hardbyte @pierreluctg
any indication when you release a version based on the develop branch? this feature is really interesting for us (vector devices for now)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants