BLF reader is missing direction of CAN FD Message

[fabiocrestani]

When parsing a CAN_FD_MESSAGE_64, the direction byte is ignored:

python-can/can/io/blf.py

Line 315 in 7ddea9e

channel, dlc, valid_bytes, _, can_id, _, fd_flags = members

[Matheus-Garbelini]

@fabiocrestani, @felixdivo Currently, direction of CAN messages are only parsed for CAN_FD_MESSAGE_64. Is there any way we can also save BLF with the direction information for CAN FD or normal CAN frames?
Perhaps there is some new format on the BLF spec that allows something like "CAN_MESSAGE_64" so we can save direction for classical CAN messages?

[felixdivo]

(I'm out, sorry.)

[Matheus-Garbelini]

@felixdivo you mean, you're out of this project?

[felixdivo]

@Matheus-Garbelini Yes. That's right. Just so that you don't wait for my feedback on this.

[fabiocrestani]

@Matheus-Garbelini By inspecting the code it seems that all CAN messages have a is_rx field that you can use to get the direction. Maybe you could provide a sample file for further investigation?

[Matheus-Garbelini]

Hi @fabiocrestani, thanks for the reply.
Unfortunatelly, the main point of my concern is that we cannot save the BLF with direction information.
Reading direction is fine trough the is_rx flag as you suggested, but informatino is lost if the user tries to save the same capture via BLF Writer api.

[fabiocrestani]

@Matheus-Garbelini I have extended the tests to use BLFWriter to write a file and then open it again with BLFReader: develop...fabiocrestani:extend-blf-tests

Results are good and the direction is stored in the file.
Can you check if this works for you?
Unfortunately I don't have any Vector tool to try right now.