docs: added support for commit-copy-action #1241
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for harness-design ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
harish-viswa
force-pushed
the
docs/commit-copy-action
branch
from
a7f47ad to
176921f
Compare
✅ Deploy Preview for harness-xd-review ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
harish-viswa
force-pushed
the
docs/commit-copy-action
branch
from
176921f to
d6ede6d
Compare
✅ Deploy Preview for harness-xd-review ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
harish-viswa
force-pushed
the
docs/commit-copy-action
branch
from
d6ede6d to
37c3dbd
Compare
knagurski
reviewed
Mar 14, 2025
Co-authored-by: Kevin Nagurski <[email protected]>
Co-authored-by: Kevin Nagurski <[email protected]>
Co-authored-by: Kevin Nagurski <[email protected]>
Co-authored-by: Kevin Nagurski <[email protected]>
Co-authored-by: Kevin Nagurski <[email protected]>
Co-authored-by: Kevin Nagurski <[email protected]>
Co-authored-by: Kevin Nagurski <[email protected]>
knagurski
reviewed
Apr 2, 2025
There was a problem hiding this comment.
Can we rename this file to match the name of the component?
Comment on lines
+41
to
+42
| sha="abc1234" | ||
| toCommitDetails={({ sha }) => `/commit/${sha}`} |
There was a problem hiding this comment.
Can we add the inline comments to describe the props?
Suggested change
| sha="abc1234" | |
| toCommitDetails={({ sha }) => `/commit/${sha}`} | |
| sha="abc1234" // SHA hash to copy to clipboard | |
| toCommitDetails={({ sha }) => `/commit/${sha}`} // callback to get the unique URL to navigate to on click |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #1238