FFM-11660 Use set instead of set with limit

Author: erdirowlands

Diff for: analyticsservice/analytics.go

@@ -49,7 +49,6 @@ type SafeAnalyticsCache[K comparable, V any] interface {
 // SafeSeenTargetsCache extends SafeAnalyticsCache and adds behavior specific to seen targets
 type SafeSeenTargetsCache[K comparable, V any] interface {
 	SafeAnalyticsCache[K, V]
-	setWithLimit(key K, value V)
 	isLimitExceeded() bool
 }
 
@@ -170,7 +169,7 @@ func (as *AnalyticsService) listener() {
 		}
 
 		// Update seen targets
-		as.seenTargets.setWithLimit(ad.target.Identifier, true)
+		as.seenTargets.set(ad.target.Identifier, true)
 
 		// Update target metrics
 		if as.targetAnalytics.size() < maxTargetEntries {

Diff for: analyticsservice/safe_maps_test.go

@@ -102,15 +102,15 @@ func TestSafeSeenTargets(t *testing.T) {
 	}
 
 	// Add one more item to exceed the limit
-	s.setWithLimit("target4", true)
+	s.set("target4", true)
 
 	// Ensure limitExceeded is true after exceeding the limit
 	if !s.isLimitExceeded() {
 		t.Errorf("Limit should be exceeded after adding target4")
 	}
 
 	// Ensure that new items are not added once the limit is exceeded
-	s.setWithLimit("target5", true)
+	s.set("target5", true)
 	if _, exists := s.get("target5"); exists {
 		t.Errorf("target5 should not have been added as the limit was exceeded")
 	}
@@ -123,7 +123,7 @@ func TestSafeSeenTargets(t *testing.T) {
 	}
 
 	// Add items again after clearing
-	s.setWithLimit("target6", true)
+	s.set("target6", true)
 	if _, exists := s.get("target6"); !exists {
 		t.Errorf("target6 should have been added after clearing the map")
 	}
@@ -142,7 +142,7 @@ func TestSafeSeenTargets(t *testing.T) {
 			go func(i int) {
 				defer wg.Done()
 				key := "target" + fmt.Sprint(i)
-				s.setWithLimit(key, true)
+				s.set(key, true)
 			}(i)
 		}
 
@@ -172,5 +172,5 @@ func TestSafeSeenTargets(t *testing.T) {
 			t.Errorf("Map size should be 0 after clearing, got %d", s.size())
 		}
 	})
-	
+
 }

Diff for: analyticsservice/safe_seen_targets_map.go

@@ -20,11 +20,8 @@ func newSafeSeenTargets(maxSize int) SafeSeenTargetsCache[string, bool] {
 	}
 }
 
-func (s *safeSeenTargets) setWithLimit(key string, seen bool) {
-	if s.limitExceeded.Load() {
-		return
-	}
-
+// The regular set method just calls SetWithLimit
+func (s *safeSeenTargets) set(key string, seen bool) {
 	s.Lock()
 	defer s.Unlock()
 
@@ -36,11 +33,6 @@ func (s *safeSeenTargets) setWithLimit(key string, seen bool) {
 	s.data[key] = seen
 }
 
-// The regular set method just calls SetWithLimit
-func (s *safeSeenTargets) set(key string, seen bool) {
-	s.setWithLimit(key, seen)
-}
-
 func (s *safeSeenTargets) get(key string) (bool, bool) {
 	s.RLock()
 	defer s.RUnlock()