Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Protobuf is deprecated #338

Open
Smidra opened this issue Mar 26, 2025 · 0 comments · May be fixed by #340
Open

Protobuf is deprecated #338

Smidra opened this issue Mar 26, 2025 · 0 comments · May be fixed by #340

Comments

@Smidra
Copy link

Smidra commented Mar 26, 2025

Hello,
protobuf from 'github.com/golang/protobuf' is deprecated and should be superseded by 'google.golang.org/protobuf'. It possible the team missed to replace the new dependency in some files. Like this, all projects will have the deprecated package as dependency.

Please check If my changes don't break code. I am not sure if the empty packages are compatible.

In gprc_stdio.go

empty "google.golang.org/protobuf/types/known/emptypb"

And in plugin_test.go

empty "google.golang.org/protobuf/types/known/emptypb"

Thanks a lot for your work. Appreciate it.

@antegral antegral linked a pull request Mar 29, 2025 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant