Skip to content

Commit b991f91

Browse files
Simplify 'NewVersion' a bit (#52)
1 parent d7f6c9b commit b991f91

File tree

1 file changed

+2
-4
lines changed

1 file changed

+2
-4
lines changed

version.go

+2-4
Original file line numberDiff line numberDiff line change
@@ -64,16 +64,14 @@ func newVersion(v string, pattern *regexp.Regexp) (*Version, error) {
6464
}
6565
segmentsStr := strings.Split(matches[1], ".")
6666
segments := make([]int64, len(segmentsStr))
67-
si := 0
6867
for i, str := range segmentsStr {
6968
val, err := strconv.ParseInt(str, 10, 64)
7069
if err != nil {
7170
return nil, fmt.Errorf(
7271
"Error parsing version: %s", err)
7372
}
7473

75-
segments[i] = int64(val)
76-
si++
74+
segments[i] = val
7775
}
7876

7977
// Even though we could support more than three segments, if we
@@ -92,7 +90,7 @@ func newVersion(v string, pattern *regexp.Regexp) (*Version, error) {
9290
metadata: matches[10],
9391
pre: pre,
9492
segments: segments,
95-
si: si,
93+
si: len(segmentsStr),
9694
original: v,
9795
}, nil
9896
}

0 commit comments

Comments
 (0)