Skip to content

Commit 9656f04

Browse files
committed
fix: remove "like" from sql keywords checked in fuzzing
1 parent 43eb817 commit 9656f04

File tree

1 file changed

+12
-3
lines changed

1 file changed

+12
-3
lines changed

mql_test.go

+12-3
Original file line numberDiff line numberDiff line change
@@ -95,6 +95,15 @@ func TestParse(t *testing.T) {
9595
Args: []any{"bob", "%alice%", "eve"},
9696
},
9797
},
98+
{
99+
name: "success-dd",
100+
query: "nAme%\"\"",
101+
model: &testModel{},
102+
want: &mql.WhereClause{
103+
Condition: "name like ?",
104+
Args: []any{"%%"},
105+
},
106+
},
98107
{
99108
name: "err-leftExpr-without-op",
100109
query: "age (name=\"alice\")",
@@ -261,7 +270,7 @@ func Fuzz_mqlParse(f *testing.F) {
261270
f.Fuzz(func(t *testing.T, s string) {
262271
where, err := mql.Parse(s, testModel{})
263272
if err == nil {
264-
for _, kw := range sqlKeywords {
273+
for _, kw := range sqlKeywordsExceptLike {
265274
if strings.Contains(strings.ToLower(where.Condition), kw) {
266275
t.Errorf("unexpected sql keyword %q in %s", kw, where.Condition)
267276
}
@@ -270,11 +279,11 @@ func Fuzz_mqlParse(f *testing.F) {
270279
})
271280
}
272281

273-
var sqlKeywords = []string{
282+
var sqlKeywordsExceptLike = []string{
274283
"select", "from", "where", "join", "left", "right", "inner", "outer",
275284
"on", "group", "by", "order", "having", "insert", "update", "delete",
276285
"values", "set", "as", "distinct", "limit", "offset", "and", "or",
277-
"not", "in", "like", "between", "is", "null", "true", "false",
286+
"not", "in", "between", "is", "null", "true", "false",
278287
"case", "when", "then", "else", "end", "while", "for", "foreach",
279288
"create", "alter", "drop", "table", "view", "index", "sequence",
280289
"database", "schema", "function", "procedure", "trigger", "event",

0 commit comments

Comments
 (0)