From e22ef543e60169423a4d1fafc9fb7ad85c44365b Mon Sep 17 00:00:00 2001 From: Selena Goods Date: Fri, 19 Apr 2024 14:50:47 -0400 Subject: [PATCH 1/2] Write the node URL for `AutoLink` nodes --- internal/mdplain/renderer.go | 5 ++++- internal/mdplain/testdata/markdown.md | 1 + internal/mdplain/testdata/mdplain.txt | 1 + 3 files changed, 6 insertions(+), 1 deletion(-) diff --git a/internal/mdplain/renderer.go b/internal/mdplain/renderer.go index 55965dc7..93bd5ec7 100644 --- a/internal/mdplain/renderer.go +++ b/internal/mdplain/renderer.go @@ -61,9 +61,12 @@ func (r *TextRender) Render(w io.Writer, source []byte, n ast.Node) error { return ast.WalkSkipChildren, nil } return ast.WalkContinue, nil - case *ast.AutoLink, *extAST.Strikethrough: + case *extAST.Strikethrough: out.Write(node.Text(source)) return ast.WalkContinue, nil + case *ast.AutoLink: + out.Write(node.URL(source)) + return ast.WalkSkipChildren, nil case *ast.CodeSpan: out.Write(node.Text(source)) return ast.WalkSkipChildren, nil diff --git a/internal/mdplain/testdata/markdown.md b/internal/mdplain/testdata/markdown.md index f5c1eccc..952e82ee 100644 --- a/internal/mdplain/testdata/markdown.md +++ b/internal/mdplain/testdata/markdown.md @@ -50,6 +50,7 @@ These are the elements outlined in John Gruber’s original design document. All [Relative Link](#Code) +Plain URL: https://www.markdownguide.org ### Image diff --git a/internal/mdplain/testdata/mdplain.txt b/internal/mdplain/testdata/mdplain.txt index c158f0c1..d7dcbee5 100644 --- a/internal/mdplain/testdata/mdplain.txt +++ b/internal/mdplain/testdata/mdplain.txt @@ -23,6 +23,7 @@ Horizontal Rule Link Markdown Guide https://www.markdownguide.org Relative Link +Plain URL: https://www.markdownguide.org Image Extended Syntax From 3bcb790bfeedbce118592ec3586c2db6d80e2ec6 Mon Sep 17 00:00:00 2001 From: Selena Goods Date: Fri, 19 Apr 2024 15:42:45 -0400 Subject: [PATCH 2/2] Add changelog entry --- .changes/unreleased/BUG FIXES-20240419-154226.yaml | 6 ++++++ 1 file changed, 6 insertions(+) create mode 100644 .changes/unreleased/BUG FIXES-20240419-154226.yaml diff --git a/.changes/unreleased/BUG FIXES-20240419-154226.yaml b/.changes/unreleased/BUG FIXES-20240419-154226.yaml new file mode 100644 index 00000000..454ac183 --- /dev/null +++ b/.changes/unreleased/BUG FIXES-20240419-154226.yaml @@ -0,0 +1,6 @@ +kind: BUG FIXES +body: 'generate: fixed a bug where the `plainmarkdown` function did not output plain + URLs' +time: 2024-04-19T15:42:26.250348-04:00 +custom: + Issue: "361"