SEC-090: Automated trusted workflow pinning (2024-08-19) (#1028)

* Result of tsccr-helper -log-level=info gha update -latest .

* Resolve linter errors and warnings

---------

Co-authored-by: hashicorp-tsccr[bot] <hashicorp-tsccr[bot]@users.noreply.github.com>
Co-authored-by: Selena Goods <[email protected]>

Author: 2 people

.github/workflows/ci-go.yml

@@ -88,7 +88,7 @@ jobs:
       - run: go mod download
       - run: go test -coverprofile=coverage.out ./...
       - run: go tool cover -html=coverage.out -o coverage.html
-      - uses: actions/upload-artifact@89ef406dd8d7e03cfd12d9e0a4a378f454709029 # v4.3.5
+      - uses: actions/upload-artifact@834a144ee995460fba8ed112a2fc961b36a5ec5a # v4.3.6
         with:
           name: go-${{ matrix.go-version }}-coverage
           path: coverage.html

.golangci.yml

@@ -11,7 +11,6 @@ linters:
     - forcetypeassert
     - gofmt
     - gosimple
-    - govet
     - ineffassign
     - makezero
     - misspell
@@ -23,6 +22,7 @@ linters:
     - unconvert
     - unparam
     - unused
+    - govet
 
 run:
   # Prevent false positive timeouts in CI

internal/privatestate/data.go

@@ -72,9 +72,9 @@ func (d *Data) Bytes(ctx context.Context) ([]byte, diag.Diagnostics) {
 			if !json.Valid(v) {
 				diags.AddError(
 					"Error Encoding Private State",
-					fmt.Sprintf("An error was encountered when validating private state value."+
-						"The value associated with key %q is is not valid JSON.\n\n"+
-						"This is always a problem with Terraform or terraform-plugin-framework. Please report this to the provider developer.", k),
+					"An error was encountered when validating private state value."+
+						fmt.Sprintf("The value associated with key %q is is not valid JSON.\n\n", k)+
+						"This is always a problem with Terraform or terraform-plugin-framework. Please report this to the provider developer.",
 				)
 
 				tflog.Error(ctx, "error encoding private state: invalid JSON value", map[string]interface{}{"key": k, "value": v})