Added "null-ness" and "unknown-ness" tests to all the types.*

Ivan De Marino · Ivan De Marino · commit 859e20527eda · 2022-05-20T14:00:33.000+01:00
diff --git a/types/bool_test.go b/types/bool_test.go
@@ -75,6 +75,12 @@ func testBoolValueFromTerraform(t *testing.T, direct bool) {
 			if !got.Equal(test.expectation) {
 				t.Errorf("Expected %+v, got %+v", test.expectation, got)
 			}
+			if test.expectation.IsNull() != test.input.IsNull() {
+				t.Errorf("Expected null-ness match: expected %t, got %t", test.expectation.IsNull(), test.input.IsNull())
+			}
+			if test.expectation.IsUnknown() != !test.input.IsKnown() {
+				t.Errorf("Expected unknown-ness match: expected %t, got %t", test.expectation.IsUnknown(), !test.input.IsKnown())
+			}
 		})
 	}
 }
diff --git a/types/float64_test.go b/types/float64_test.go
@@ -6,6 +6,7 @@ import (
 	"testing"
 
 	"github.com/google/go-cmp/cmp"
+
 	"github.com/hashicorp/terraform-plugin-framework/attr"
 
 	"github.com/hashicorp/terraform-plugin-go/tftypes"
@@ -76,6 +77,12 @@ func testFloat64ValueFromTerraform(t *testing.T, direct bool) {
 			if diff := cmp.Diff(got, test.expectation); diff != "" {
 				t.Errorf("Unexpected response (+wanted, -got): %s", diff)
 			}
+			if test.expectation.IsNull() != test.input.IsNull() {
+				t.Errorf("Expected null-ness match: expected %t, got %t", test.expectation.IsNull(), test.input.IsNull())
+			}
+			if test.expectation.IsUnknown() != !test.input.IsKnown() {
+				t.Errorf("Expected unknown-ness match: expected %t, got %t", test.expectation.IsUnknown(), !test.input.IsKnown())
+			}
 		})
 	}
 }
diff --git a/types/int64_test.go b/types/int64_test.go
@@ -6,6 +6,7 @@ import (
 	"testing"
 
 	"github.com/google/go-cmp/cmp"
+
 	"github.com/hashicorp/terraform-plugin-framework/attr"
 
 	"github.com/hashicorp/terraform-plugin-go/tftypes"
@@ -72,6 +73,12 @@ func testInt64ValueFromTerraform(t *testing.T, direct bool) {
 			if !got.Equal(test.expectation) {
 				t.Errorf("Expected %+v, got %+v", test.expectation, got)
 			}
+			if test.expectation.IsNull() != test.input.IsNull() {
+				t.Errorf("Expected null-ness match: expected %t, got %t", test.expectation.IsNull(), test.input.IsNull())
+			}
+			if test.expectation.IsUnknown() != !test.input.IsKnown() {
+				t.Errorf("Expected unknown-ness match: expected %t, got %t", test.expectation.IsUnknown(), !test.input.IsKnown())
+			}
 		})
 	}
 }
diff --git a/types/list_test.go b/types/list_test.go
@@ -5,8 +5,9 @@ import (
 	"testing"
 
 	"github.com/google/go-cmp/cmp"
-	"github.com/hashicorp/terraform-plugin-framework/attr"
 	"github.com/hashicorp/terraform-plugin-go/tftypes"
+
+	"github.com/hashicorp/terraform-plugin-framework/attr"
 )
 
 func TestListTypeTerraformType(t *testing.T) {
@@ -203,6 +204,12 @@ func TestListTypeValueFromTerraform(t *testing.T) {
 			if diff := cmp.Diff(got, test.expected); diff != "" {
 				t.Errorf("Unexpected diff (-expected, +got): %s", diff)
 			}
+			if test.expected != nil && test.expected.IsNull() != test.input.IsNull() {
+				t.Errorf("Expected null-ness match: expected %t, got %t", test.expected.IsNull(), test.input.IsNull())
+			}
+			if test.expected != nil && test.expected.IsUnknown() != !test.input.IsKnown() {
+				t.Errorf("Expected unknown-ness match: expected %t, got %t", test.expected.IsUnknown(), !test.input.IsKnown())
+			}
 		})
 	}
 }
diff --git a/types/map_test.go b/types/map_test.go
@@ -6,8 +6,9 @@ import (
 	"testing"
 
 	"github.com/google/go-cmp/cmp"
-	"github.com/hashicorp/terraform-plugin-framework/attr"
 	"github.com/hashicorp/terraform-plugin-go/tftypes"
+
+	"github.com/hashicorp/terraform-plugin-framework/attr"
 )
 
 func TestMapTypeTerraformType(t *testing.T) {
@@ -162,6 +163,12 @@ func TestMapTypeValueFromTerraform(t *testing.T) {
 			if diff := cmp.Diff(test.expected, got); diff != "" {
 				t.Errorf("unexpected result (-expected, +got): %s", diff)
 			}
+			if test.expected != nil && test.expected.IsNull() != test.input.IsNull() {
+				t.Errorf("Expected null-ness match: expected %t, got %t", test.expected.IsNull(), test.input.IsNull())
+			}
+			if test.expected != nil && test.expected.IsUnknown() != !test.input.IsKnown() {
+				t.Errorf("Expected unknown-ness match: expected %t, got %t", test.expected.IsUnknown(), !test.input.IsKnown())
+			}
 		})
 	}
 }
diff --git a/types/number_test.go b/types/number_test.go
@@ -6,6 +6,7 @@ import (
 	"testing"
 
 	"github.com/google/go-cmp/cmp"
+
 	"github.com/hashicorp/terraform-plugin-framework/attr"
 
 	"github.com/hashicorp/terraform-plugin-go/tftypes"
@@ -76,6 +77,12 @@ func testNumberValueFromTerraform(t *testing.T, direct bool) {
 			if !got.Equal(test.expectation) {
 				t.Errorf("Expected %+v, got %+v", test.expectation, got)
 			}
+			if test.expectation.IsNull() != test.input.IsNull() {
+				t.Errorf("Expected null-ness match: expected %t, got %t", test.expectation.IsNull(), test.input.IsNull())
+			}
+			if test.expectation.IsUnknown() != !test.input.IsKnown() {
+				t.Errorf("Expected unknown-ness match: expected %t, got %t", test.expectation.IsUnknown(), !test.input.IsKnown())
+			}
 		})
 	}
 }
diff --git a/types/object_test.go b/types/object_test.go
@@ -6,8 +6,9 @@ import (
 	"testing"
 
 	"github.com/google/go-cmp/cmp"
-	"github.com/hashicorp/terraform-plugin-framework/attr"
 	"github.com/hashicorp/terraform-plugin-go/tftypes"
+
+	"github.com/hashicorp/terraform-plugin-framework/attr"
 )
 
 func TestObjectTypeTerraformType_simple(t *testing.T) {
@@ -199,6 +200,12 @@ func TestObjectTypeValueFromTerraform(t *testing.T) {
 			if diff := cmp.Diff(test.expected, got); diff != "" {
 				t.Errorf("unexpected result (-expected, +got): %s", diff)
 			}
+			if test.expected != nil && test.expected.IsNull() != test.input.IsNull() {
+				t.Errorf("Expected null-ness match: expected %t, got %t", test.expected.IsNull(), test.input.IsNull())
+			}
+			if test.expected != nil && test.expected.IsUnknown() != !test.input.IsKnown() {
+				t.Errorf("Expected unknown-ness match: expected %t, got %t", test.expected.IsUnknown(), !test.input.IsKnown())
+			}
 		})
 	}
 }
diff --git a/types/set_test.go b/types/set_test.go
@@ -6,9 +6,10 @@ import (
 	"testing"
 
 	"github.com/google/go-cmp/cmp"
+	"github.com/hashicorp/terraform-plugin-go/tftypes"
+
 	"github.com/hashicorp/terraform-plugin-framework/attr"
 	"github.com/hashicorp/terraform-plugin-framework/diag"
-	"github.com/hashicorp/terraform-plugin-go/tftypes"
 )
 
 func TestSetTypeTerraformType(t *testing.T) {
@@ -229,6 +230,12 @@ func TestSetTypeValueFromTerraform(t *testing.T) {
 			if diff := cmp.Diff(got, test.expected); diff != "" {
 				t.Errorf("Unexpected diff (-expected, +got): %s", diff)
 			}
+			if test.expected != nil && test.expected.IsNull() != test.input.IsNull() {
+				t.Errorf("Expected null-ness match: expected %t, got %t", test.expected.IsNull(), test.input.IsNull())
+			}
+			if test.expected != nil && test.expected.IsUnknown() != !test.input.IsKnown() {
+				t.Errorf("Expected unknown-ness match: expected %t, got %t", test.expected.IsUnknown(), !test.input.IsKnown())
+			}
 		})
 	}
 }
diff --git a/types/string_test.go b/types/string_test.go
@@ -6,6 +6,7 @@ import (
 	"testing"
 
 	"github.com/google/go-cmp/cmp"
+
 	"github.com/hashicorp/terraform-plugin-framework/attr"
 
 	"github.com/hashicorp/terraform-plugin-go/tftypes"
@@ -72,6 +73,12 @@ func testStringValueFromTerraform(t *testing.T, direct bool) {
 			if !got.Equal(test.expectation) {
 				t.Errorf("Expected %+v, got %+v", test.expectation, got)
 			}
+			if test.expectation.IsNull() != test.input.IsNull() {
+				t.Errorf("Expected null-ness match: expected %t, got %t", test.expectation.IsNull(), test.input.IsNull())
+			}
+			if test.expectation.IsUnknown() != !test.input.IsKnown() {
+				t.Errorf("Expected unknown-ness match: expected %t, got %t", test.expectation.IsUnknown(), !test.input.IsKnown())
+			}
 		})
 	}
 }

Original file line number	Diff line number	Diff line change
`@@ -75,6 +75,12 @@ func testBoolValueFromTerraform(t *testing.T, direct bool) {`
`75`	`75`	`if !got.Equal(test.expectation) {`
`76`	`76`	`t.Errorf("Expected %+v, got %+v", test.expectation, got)`
`77`	`77`	`}`
	`78`	`+ if test.expectation.IsNull() != test.input.IsNull() {`
	`79`	`+ t.Errorf("Expected null-ness match: expected %t, got %t", test.expectation.IsNull(), test.input.IsNull())`
	`80`	`+ }`
	`81`	`+ if test.expectation.IsUnknown() != !test.input.IsKnown() {`
	`82`	`+ t.Errorf("Expected unknown-ness match: expected %t, got %t", test.expectation.IsUnknown(), !test.input.IsKnown())`
	`83`	`+ }`
`78`	`84`	`})`
`79`	`85`	`}`
`80`	`86`	`}`
Original file line number	Diff line number	Diff line change
`@@ -6,6 +6,7 @@ import (`
`6`	`6`	`"testing"`
`7`	`7`
`8`	`8`	`"github.com/google/go-cmp/cmp"`
	`9`	`+`
`9`	`10`	`"github.com/hashicorp/terraform-plugin-framework/attr"`
`10`	`11`
`11`	`12`	`"github.com/hashicorp/terraform-plugin-go/tftypes"`
`@@ -76,6 +77,12 @@ func testFloat64ValueFromTerraform(t *testing.T, direct bool) {`
`76`	`77`	`if diff := cmp.Diff(got, test.expectation); diff != "" {`
`77`	`78`	`t.Errorf("Unexpected response (+wanted, -got): %s", diff)`
`78`	`79`	`}`
	`80`	`+ if test.expectation.IsNull() != test.input.IsNull() {`
	`81`	`+ t.Errorf("Expected null-ness match: expected %t, got %t", test.expectation.IsNull(), test.input.IsNull())`
	`82`	`+ }`
	`83`	`+ if test.expectation.IsUnknown() != !test.input.IsKnown() {`
	`84`	`+ t.Errorf("Expected unknown-ness match: expected %t, got %t", test.expectation.IsUnknown(), !test.input.IsKnown())`
	`85`	`+ }`
`79`	`86`	`})`
`80`	`87`	`}`
`81`	`88`	`}`
Original file line number	Diff line number	Diff line change
`@@ -5,8 +5,9 @@ import (`
`5`	`5`	`"testing"`
`6`	`6`
`7`	`7`	`"github.com/google/go-cmp/cmp"`
`8`		`- "github.com/hashicorp/terraform-plugin-framework/attr"`
`9`	`8`	`"github.com/hashicorp/terraform-plugin-go/tftypes"`
	`9`	`+`
	`10`	`+ "github.com/hashicorp/terraform-plugin-framework/attr"`
`10`	`11`	`)`
`11`	`12`
`12`	`13`	`func TestListTypeTerraformType(t *testing.T) {`
`@@ -203,6 +204,12 @@ func TestListTypeValueFromTerraform(t *testing.T) {`
`203`	`204`	`if diff := cmp.Diff(got, test.expected); diff != "" {`
`204`	`205`	`t.Errorf("Unexpected diff (-expected, +got): %s", diff)`
`205`	`206`	`}`
	`207`	`+ if test.expected != nil && test.expected.IsNull() != test.input.IsNull() {`
	`208`	`+ t.Errorf("Expected null-ness match: expected %t, got %t", test.expected.IsNull(), test.input.IsNull())`
	`209`	`+ }`
	`210`	`+ if test.expected != nil && test.expected.IsUnknown() != !test.input.IsKnown() {`
	`211`	`+ t.Errorf("Expected unknown-ness match: expected %t, got %t", test.expected.IsUnknown(), !test.input.IsKnown())`
	`212`	`+ }`
`206`	`213`	`})`
`207`	`214`	`}`
`208`	`215`	`}`
Original file line number	Diff line number	Diff line change
`@@ -6,8 +6,9 @@ import (`
`6`	`6`	`"testing"`
`7`	`7`
`8`	`8`	`"github.com/google/go-cmp/cmp"`
`9`		`- "github.com/hashicorp/terraform-plugin-framework/attr"`
`10`	`9`	`"github.com/hashicorp/terraform-plugin-go/tftypes"`
	`10`	`+`
	`11`	`+ "github.com/hashicorp/terraform-plugin-framework/attr"`
`11`	`12`	`)`
`12`	`13`
`13`	`14`	`func TestMapTypeTerraformType(t *testing.T) {`
`@@ -162,6 +163,12 @@ func TestMapTypeValueFromTerraform(t *testing.T) {`
`162`	`163`	`if diff := cmp.Diff(test.expected, got); diff != "" {`
`163`	`164`	`t.Errorf("unexpected result (-expected, +got): %s", diff)`
`164`	`165`	`}`
	`166`	`+ if test.expected != nil && test.expected.IsNull() != test.input.IsNull() {`
	`167`	`+ t.Errorf("Expected null-ness match: expected %t, got %t", test.expected.IsNull(), test.input.IsNull())`
	`168`	`+ }`
	`169`	`+ if test.expected != nil && test.expected.IsUnknown() != !test.input.IsKnown() {`
	`170`	`+ t.Errorf("Expected unknown-ness match: expected %t, got %t", test.expected.IsUnknown(), !test.input.IsKnown())`
	`171`	`+ }`
`165`	`172`	`})`
`166`	`173`	`}`
`167`	`174`	`}`
Original file line number	Diff line number	Diff line change
`@@ -6,9 +6,10 @@ import (`
`6`	`6`	`"testing"`
`7`	`7`
`8`	`8`	`"github.com/google/go-cmp/cmp"`
	`9`	`+ "github.com/hashicorp/terraform-plugin-go/tftypes"`
	`10`	`+`
`9`	`11`	`"github.com/hashicorp/terraform-plugin-framework/attr"`
`10`	`12`	`"github.com/hashicorp/terraform-plugin-framework/diag"`
`11`		`- "github.com/hashicorp/terraform-plugin-go/tftypes"`
`12`	`13`	`)`
`13`	`14`
`14`	`15`	`func TestSetTypeTerraformType(t *testing.T) {`
`@@ -229,6 +230,12 @@ func TestSetTypeValueFromTerraform(t *testing.T) {`
`229`	`230`	`if diff := cmp.Diff(got, test.expected); diff != "" {`
`230`	`231`	`t.Errorf("Unexpected diff (-expected, +got): %s", diff)`
`231`	`232`	`}`
	`233`	`+ if test.expected != nil && test.expected.IsNull() != test.input.IsNull() {`
	`234`	`+ t.Errorf("Expected null-ness match: expected %t, got %t", test.expected.IsNull(), test.input.IsNull())`
	`235`	`+ }`
	`236`	`+ if test.expected != nil && test.expected.IsUnknown() != !test.input.IsKnown() {`
	`237`	`+ t.Errorf("Expected unknown-ness match: expected %t, got %t", test.expected.IsUnknown(), !test.input.IsKnown())`
	`238`	`+ }`
`232`	`239`	`})`
`233`	`240`	`}`
`234`	`241`	`}`