internal/fwserver: Move write-only nullification to earlier in PlanResourceChange #1097
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ted attributes as unknown
austinvalle
approved these changes
Feb 19, 2025
|
Thanks @SBGoods for the instant fix! @austinvalle I can confirm this solved my issue #1096. I'll continue developing my provider and report new issues if any. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #1096
During PlanResourceChange, computed attributes that are
nullin the configuration are marked asunknown. This logic only runs when there is a non-null planned state and the planned state is not equal to the prior state. If a write-only attribute is set in config, then the prior state (which is alwaysnull) and planned state (which contains the config value) will always differ causingnullcomputed values to always be marked asunknowninstead of using the prior value. This causes perpetual diffs after resource creation if a write-only attribute is set in config and the resource has non-null computed attribute values in state.The fix moves the write-only value nullification for the planned state to happen before this check.