Add support for objects #38
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Depends on #35. |
paddycarver
force-pushed
the
paddy_types_object
branch
from
07e2d66 to
a6c995b
Compare
Merged
paddycarver
force-pushed
the
paddy_types_object
branch
2 times, most recently
from
509d693 to
74368f9
Compare
It says it's wrong, but it's what the standard library tells us to do? Who knows.
Debugging this was kind of a pain. Really, we should just be using attribute paths for all of this.
Finish getting Object and ObjectType implemented and tested.
We have (most) the types we need for them now.
paddycarver
force-pushed
the
paddy_types_object
branch
from
e80858d to
cc7ad4d
Compare
|
Still happy with this @kmoe ? |
|
Yep! Hope you don't mind if I merge... |
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the Object type and the ObjectType type. typetypetype.
Depends on #41.