Skip to content

Consider changing attr.Value implementations in types package to have Value in their name #67

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
paddycarver opened this issue Jul 13, 2021 · 3 comments
Closed

Consider changing attr.Value implementations in types package to have Value in their name #67

paddycarver opened this issue Jul 13, 2021 · 3 comments
Labels
breaking-change This PR introduces a breaking change or the resolution of this issue may require a breaking change. types Issues and pull requests about our types abstraction and implementations.
Milestone
v1.0.0

Comments

@paddycarver
Copy link
Contributor

It's very confusing to have types.String that doesn't define an actual type constraint, and instead holds a value. Maybe types.StringValue is clearer?
@bflad
Copy link
Contributor

bflad commented Jul 13, 2021

I'm 👍 for this type of change -- I personally appreciate the pattern of {InterfaceTypeName} and {Concrete}{InterfaceTypeName} where possible.

@paddycarver paddycarver added the breaking-change This PR introduces a breaking change or the resolution of this issue may require a breaking change. label Sep 9, 2021
@paddycarver paddycarver added the types Issues and pull requests about our types abstraction and implementations. label Sep 21, 2021
@bflad bflad added this to the v1.0.0 milestone Mar 16, 2022
@bflad
Copy link
Contributor

bflad commented Sep 23, 2022

We're discussing a different approach to this problem over in #447, which will introduce its own breaking changes, so I think it is best to track it there. 👍

@bflad bflad closed this as completed Sep 23, 2022
@github-actions
Copy link

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 24, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
breaking-change This PR introduces a breaking change or the resolution of this issue may require a breaking change. types Issues and pull requests about our types abstraction and implementations.
Projects
None yet
Milestone
v1.0.0
Development

No branches or pull requests
2 participants
@paddycarver @bflad