Skip to content

Commit 5892f42

Browse files
committed
Add changelog.d entry for #7344
1 parent 1068755 commit 5892f42

File tree

3 files changed

+24
-27
lines changed

3 files changed

+24
-27
lines changed

cabal-install/main/Main.hs

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,6 @@
1313
-- Entry point to the default cabal-install front-end.
1414
-----------------------------------------------------------------------------
1515

16-
{-# OPTIONS_GHC -Wno-deferred-type-errors #-}
1716
module Main (main) where
1817

1918
import Distribution.Client.Setup

cabal-install/tests/UnitTests/Distribution/Client/Init/Golden.hs

Lines changed: 0 additions & 26 deletions
Original file line numberDiff line numberDiff line change
@@ -71,32 +71,6 @@ tests v initFlags _comp pkgIx srcDb = testGroup "golden"
7171
pkgName = evalPrompt (packageNamePrompt srcDb initFlags)
7272
$ fromList ["test-package", "y"]
7373

74-
-- goldenCabalTests
75-
-- :: Verbosity
76-
-- -> InstalledPackageIndex
77-
-- -> FilePath
78-
-- -> PackageName
79-
-- -> SourcePackageDb
80-
-- -> TestTree
81-
-- goldenCabalTests v pkgIx pkgDir pkgName srcDb = testGroup ".cabal golden tests"
82-
-- [ goldenVsString "Create lib .cabal project" (goldenCabal "lib-cabal.golden") $
83-
-- runGoldenCabal emptyFlags { packageType = Flag Library }
84-
-- , goldenVsString "Create lib+test .cabal project" (goldenCabal "lib-test-cabal.golden") $
85-
-- runGoldenCabal emptyFlags
86-
-- { packageType = Flag Library
87-
-- , initializeTestSuite = Flag True
88-
-- }
89-
-- , goldenVsString "Create lib .cabal project" (goldenCabal "exe-cabal.golden") $
90-
-- runGoldenCabal emptyFlags { packageType = Flag Executable }
91-
-- ]
92-
-- where
93-
-- runGoldenCabal flags =
94-
-- case _runPrompt (createProject v pkgIx srcDb flags) of
95-
-- Right (t, _) -> return . BS8.pack $ showFields'
96-
-- annCommentLines postProcessFieldLines
97-
-- 4 [mkCabalStanza opts t]
98-
-- Left e -> assertFailure $ show e
99-
10074
goldenPkgDescTests
10175
:: Verbosity
10276
-> SourcePackageDb

changelog.d/pr-7344

Lines changed: 24 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,24 @@
1+
synopsis: Cabal init rewrite
2+
pr: #7344
3+
issues: #7273 #7256 #7255 #7251 #6758 #6864 #1074
4+
significance: significant
5+
description: {
6+
7+
- Restructures the `cabal init` command to fix historical
8+
issues. All flags are preserved.
9+
- Codebases for interactive and non-interactive flags
10+
are disentangled.
11+
- Data structures now exploit relevant stanza structure
12+
and formatters only care about stanza data
13+
- Heuristics and prompts have a pure and impure implementation.
14+
15+
- Sets default behavior to be `--interactive` as opposed to
16+
`--non-interactive`.
17+
18+
- Rewrites tests to achieve 98% coverage
19+
- Golden files now test every stanza individually
20+
- Every flag is covered by a unit test
21+
- Interactive, simple, and non-interactive workflows are
22+
covered.
23+
24+
}

0 commit comments

Comments
 (0)