Merge pull request #214 from jneira/ghc-haddock

Use -haddock in cabal and stack for all dependencies. 
This way hls gets comments on hover for its dependencies.

Author: jneira

Diff for: cabal.project

@@ -3,7 +3,9 @@ packages:
          ghcide
 
 tests: true
-documentation: true
+
+package *
+  ghc-options: -haddock
 
 package haskell-language-server
   test-show-details: direct

Diff for: stack-8.10.1.yaml

@@ -4,6 +4,9 @@ packages:
 - .
 - ./ghcide/
 
+ghc-options:
+  "$everything": -haddock
+
 extra-deps:
 - Cabal-3.0.2.0
 - hie-bios-0.6.1

Diff for: stack-8.6.4.yaml

@@ -4,6 +4,9 @@ packages:
 - .
 - ./ghcide/
 
+ghc-options:
+  "$everything": -haddock
+
 extra-deps:
 - aeson-1.4.3.0
 - brittany-0.12.1.1

Diff for: stack-8.6.5.yaml

@@ -4,6 +4,9 @@ packages:
 - .
 - ./ghcide/
 
+ghc-options:
+  "$everything": -haddock
+
 extra-deps:
 - ansi-terminal-0.10.2
 - base-compat-0.11.0

Diff for: stack-8.8.2.yaml

@@ -4,6 +4,9 @@ packages:
 - .
 - ./ghcide/
 
+ghc-options:
+  "$everything": -haddock
+
 extra-deps:
 - apply-refact-0.7.0.0
 - brittany-0.12.1.1

Diff for: stack-8.8.3.yaml

@@ -4,6 +4,9 @@ packages:
 - .
 - ./ghcide/
 
+ghc-options:
+  "$everything": -haddock
+
 extra-deps:
 - apply-refact-0.7.0.0
 - bytestring-trie-0.2.5.0

Diff for: stack-8.8.4.yaml

@@ -5,6 +5,9 @@ packages:
 - .
 - ./ghcide/
 
+ghc-options:
+  "$everything": -haddock
+
 extra-deps:
 - apply-refact-0.7.0.0
 - bytestring-trie-0.2.5.0

Diff for: stack.yaml

@@ -4,6 +4,9 @@ packages:
 - .
 - ./ghcide/
 
+ghc-options:
+  "$everything": -haddock
+
 extra-deps:
 - ansi-terminal-0.10.2
 - base-compat-0.11.0

Diff for: test/functional/Deferred.hs

@@ -159,7 +159,6 @@ multiMainTests :: TestTree
 multiMainTests = testGroup "multiple main modules" [
     ignoreTestBecause "Broken: Unexpected ConduitParser.empty" $
     testCase "Can load one file at a time, when more than one Main module exists"
-        -- $ runSession hieCommand fullCaps "test/testdata" $ do
         $ runSession hieCommand fullCaps "test/testdata" $ do
             _doc <- openDoc "ApplyRefact2.hs" "haskell"
             _diagsRspHlint <- skipManyTill anyNotification message :: Session PublishDiagnosticsNotification
@@ -175,4 +174,4 @@ multiMainTests = testGroup "multiple main modules" [
             let (List diags2) = diagsRsp2 ^. params . diagnostics
 
             liftIO $ show diags2 `shouldBe` "[]"
-    ]
+    ]

Diff for: test/functional/TypeDefinition.hs

@@ -75,21 +75,22 @@ tests = testGroup "type definitions" [
                                         (Range (toPos (18, 1)) (toPos (18, 26)))
                             ]
 
-    -- TODO Implement
-    -- , ignoreTestBecause "Broken" $ testCase "find type-definition of type def in component"
-    --     $ pendingWith "Finding symbols cross module is currently not supported"
-        -- $ runSession hieCommand fullCaps "test/testdata/gototest"
-        -- $ do
-        --     doc      <- openDoc "src/Lib2.hs" "haskell"
-        --     otherDoc <- openDoc "src/Lib.hs" "haskell"
-        --     closeDoc otherDoc
-        --     defs <- getTypeDefinitions doc (toPos (13, 20))
-        --     liftIO $ do
-        --       fp <- canonicalizePath "test/testdata/gototest/src/Lib.hs"
-        --       defs
-        --         `shouldBe` [ Location (filePathToUri fp)
-        --                               (Range (toPos (8, 1)) (toPos (8, 29)))
-        --                    ]
+    {--  TODO Implement
+     , ignoreTestBecause "Broken" $ testCase "find type-definition of type def in component"
+         $ pendingWith "Finding symbols cross module is currently not supported"
+         $ runSession hieCommand fullCaps "test/testdata/gototest"
+         $ do
+             doc      <- openDoc "src/Lib2.hs" "haskell"
+             otherDoc <- openDoc "src/Lib.hs" "haskell"
+             closeDoc otherDoc
+             defs <- getTypeDefinitions doc (toPos (13, 20))
+             liftIO $ do
+               fp <- canonicalizePath "test/testdata/gototest/src/Lib.hs"
+               defs
+                 `shouldBe` [ Location (filePathToUri fp)
+                                       (Range (toPos (8, 1)) (toPos (8, 29)))
+                            ]
+    --}
     , ignoreTestBecause "Broken" $ testCase "find definition of parameterized data type"
         $ runSession hieCommand fullCaps "test/testdata/gototest"
         $ do
@@ -105,4 +106,4 @@ tests = testGroup "type definitions" [
 
 --NOTE: copied from Haskell.Ide.Engine.ArtifactMap
 toPos :: (Int,Int) -> Position
-toPos (l,c) = Position (l-1) (c-1)
+toPos (l,c) = Position (l-1) (c-1)