Skip to content

Benchmark suite can fail unexpectedly #1306

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
konn opened this issue Feb 4, 2021 · 1 comment · Fixed by #1314
Closed

Benchmark suite can fail unexpectedly #1306

konn opened this issue Feb 4, 2021 · 1 comment · Fixed by #1314
Assignees
@pepeiborra
Labels
type: enhancement New feature or request

Comments

@konn
Copy link
Collaborator

konn commented Feb 4, 2021

We have a really nice benchmark suite to ensure efficiency. However, in some (unpredictable) cases, it fails due to an unexpected resource busy exception, e.g. see Benchmark #630.
Since the current benchmark suite is the most time-consuming part of a CI, which can take up to two hours, and it can unexpectedly fail at the very end of a run, it might be favourable to avoid such resource busy exceptions.
@konn konn added type: enhancement New feature or request type: testing labels Feb 4, 2021
@pepeiborra
Copy link
Collaborator

I have a fix and other improvements coming

@pepeiborra pepeiborra self-assigned this Feb 4, 2021
@pepeiborra pepeiborra mentioned this issue Feb 6, 2021
Merged
@mergify mergify bot closed this as completed in #1314 Feb 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pepeiborra pepeiborra

Labels
type: enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[benchmark] check digests for input files only haskell/haskell-language-server
2 participants
@konn @pepeiborra