Skip to content

Parse error when adding def to trailing-comma import list #3039

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
georgefst opened this issue Jul 11, 2022 · 1 comment · Fixed by #3035
Closed

Parse error when adding def to trailing-comma import list #3039

georgefst opened this issue Jul 11, 2022 · 1 comment · Fixed by #3035
Labels
component: ghcide type: bug Something isn't right: doesn't work as intended, documentation is missing/outdated, etc..

Comments

@georgefst
Copy link
Collaborator 

import Prelude (
  Bool,
 )

x = not

Running the code action to add not results in:

import Prelude (
  Bool,, not
 )

x = not

HEAD (445192e) with GHC 9.2.3. I'm pretty sure this is a regression since the last release.
@georgefst georgefst added type: bug Something isn't right: doesn't work as intended, documentation is missing/outdated, etc.. status: needs triage labels Jul 11, 2022
@kokobd
Copy link
Collaborator

kokobd commented Jul 12, 2022

Duplicate of #2958? I'm trying to fix it in #3035.

@kokobd kokobd linked a pull request Jul 12, 2022 that will close this issue
handle trailing comma in import list properly #3035
Merged
@georgefst georgefst closed this as not planned Won't fix, can't repro, duplicate, stale Jul 12, 2022
@mergify mergify bot closed this as completed in #3035 Jul 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
component: ghcide type: bug Something isn't right: doesn't work as intended, documentation is missing/outdated, etc..
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

handle trailing comma in import list properly haskell/haskell-language-server
2 participants
@georgefst @kokobd