Skip to content

Enable ignored tests: renaming and liquid haskell #527

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jneira opened this issue Oct 21, 2020 · 5 comments
Closed

Enable ignored tests: renaming and liquid haskell #527

jneira opened this issue Oct 21, 2020 · 5 comments
Labels
CI Continuous integration type: enhancement New feature or request

Comments

@jneira
Copy link
Member

jneira commented Oct 21, 2020

  • Follow up of Add tests #5
  • Some of them do not have implemented the functionality
  • We could change the cause of being ignored to help enable them progresively
@jneira
Copy link
Member Author

jneira commented Jan 19, 2021

Thanks to @peterwicksstringfield we have most tests enabled but some of them:

  • renaming
  • liquid haskell

We should add a checklist here to track them (and not include the ignored ones for concrete unresolved issues)

@peterwicksstringfield
Copy link
Contributor

I don't know quite what the tests in functional/Deferred.hs and functional/FunctionalBadProject.hs are supposed to be testing, but those files are in poor condition.

functional/Definition.hs and functional/Reference.hs will need a second look after the hiedb PR #704 gets merged, I'm expecting that many of those tests can be enabled and pass. (I don't think it would be a good idea to try to get these tests into #704. That PR is complex enough as is, and it has its own tests on the ghcide side.)

@jneira
Copy link
Member Author

jneira commented Sep 16, 2021

@peterwicksstringfield #704 is already merged, could you have the chance to take a look to mentioned modules? thanks!

@jneira jneira changed the title Enable ignored tests Enable ignored tests: renaming and liquid haskell Sep 16, 2021
@jneira
Copy link
Member Author

jneira commented Sep 16, 2021

* renaming

* liquid haskell

renaming tests are moved to its own plugin and we dont have the liquid plugin yet

@peterwicksstringfield
Copy link
Contributor

peterwicksstringfield commented Sep 23, 2021

Yeah let me take a look ... okay um, maybe merge #2235 and close this ticket? At this point all the ignored or expect failed tests have reasonable reasons, so maybe there is no need for this ticket to track them anymore?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI Continuous integration type: enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants