-
-
Notifications
You must be signed in to change notification settings - Fork 389
Enable ignored tests: renaming and liquid haskell #527
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Thanks to @peterwicksstringfield we have most tests enabled but some of them:
We should add a checklist here to track them (and not include the ignored ones for concrete unresolved issues) |
I don't know quite what the tests in functional/Deferred.hs and functional/FunctionalBadProject.hs are supposed to be testing, but those files are in poor condition. functional/Definition.hs and functional/Reference.hs will need a second look after the hiedb PR #704 gets merged, I'm expecting that many of those tests can be enabled and pass. (I don't think it would be a good idea to try to get these tests into #704. That PR is complex enough as is, and it has its own tests on the ghcide side.) |
@peterwicksstringfield #704 is already merged, could you have the chance to take a look to mentioned modules? thanks! |
renaming tests are moved to its own plugin and we dont have the liquid plugin yet |
Yeah let me take a look ... okay um, maybe merge #2235 and close this ticket? At this point all the ignored or expect failed tests have reasonable reasons, so maybe there is no need for this ticket to track them anymore? |
The text was updated successfully, but these errors were encountered: