From 05fcaa5add40581a3c0971c663ebb511cafc0592 Mon Sep 17 00:00:00 2001 From: Junyoung/Clare Jang Date: Thu, 25 Mar 2021 13:04:21 -0400 Subject: [PATCH] Update formatting hooks to not include Wingman --- CONTRIBUTING.md | 8 +++++++- nix/default.nix | 2 +- 2 files changed, 8 insertions(+), 2 deletions(-) diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index 1b6df50b9b..9aee9437f7 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -18,7 +18,7 @@ If you don't want to use [nix](https://nixos.org/guides/install-nix.html), you c "hooks": [ { "entry": "stylish-haskell --inplace", - "exclude": "(^Setup.hs$|test/testdata/.*$|test/data/.*$|^hie-compat/.*$)", + "exclude": "(^Setup.hs$|test/testdata/.*$|test/data/.*$|^hie-compat/.*$|^plugins/hls-tactics-plugin/.*$)", "files": "\\.l?hs$", "id": "stylish-haskell", "language": "system", @@ -35,6 +35,12 @@ If you don't want to use [nix](https://nixos.org/guides/install-nix.html), you c } ``` +### Why they are excluded? + +- `test/testdata` and `test/data` are there as we want to test formatting plugins. +- `hie-compat` is there as we want to keep its code as close to GHC as possible. +- `hls-tactics-plugin` is there as the main contributor of the plugin (@isovector) does not want auto-formatting. + ## Testing The tests make use of the [Tasty](https://github.com/feuerbach/tasty) test framework. diff --git a/nix/default.nix b/nix/default.nix index 5ce0b4d10a..713cf9607f 100644 --- a/nix/default.nix +++ b/nix/default.nix @@ -80,7 +80,7 @@ in (import sources.nixpkgs # default_stages = ["manual" "push"]; hooks = { stylish-haskell.enable = true; - stylish-haskell.excludes = [ "^Setup.hs$" "test/testdata/.*$" "test/data/.*$" "^hie-compat/.*$" ]; + stylish-haskell.excludes = [ "^Setup.hs$" "test/testdata/.*$" "test/data/.*$" "^hie-compat/.*$" "^plugins/hls-tactics-plugin/.*$" ]; }; }; }