Skip to content

Build docker image with ENV from Kube #105

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
duyleekun opened this issue Nov 18, 2018 · 3 comments
Closed

Build docker image with ENV from Kube #105

duyleekun opened this issue Nov 18, 2018 · 3 comments

Comments

@duyleekun
Copy link

There's a shared ENV between build and running phase. Currently, I have to duplicate the ENV from kube manifest into Dockerfile. Is there any way to do that properly yet?

@tirumaraiselvan
Copy link
Collaborator

Although this would have been an improvement in the UX but unfortunately not technically possible.

The ENV used during build must be loaded into gitkubed pod because that is the one that builds the image. So you will need to copy it either way (in the gitkubed manifest or the remote manifest). It is better UX to have the ENV in the remote manifest rather than in a global gitkubed manifest.

@duyleekun
Copy link
Author

Does current Remote object support ref to ConfigMap/Secret because I can't find it in the documents. Having ConfigMap/Secret ref-able from Remote would solve my use case.

@tirumaraiselvan
Copy link
Collaborator

That's a great suggestion. Can you please open an issue for the same?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants