server/mssql: Implement column presets

PR-URL: hasura/graphql-engine-mono#3856
GitOrigin-RevId: 8527749c33df1a5bdde29338630714e673e308ab

Author: soupi

CHANGELOG.md

@@ -105,6 +105,7 @@ function:
 - server: improve SQL generation for BigQuery backend queries involving `Orderby`.
 - server: fix regression where remote relationships would get exposed over Relay, which is unsupported
 - server: add support for customising the GraphQL schema descriptions of table columns in metadata
+- server: implement column presets for SQL Server (#8221)
 - console: fixed an issue where editing both a column's name and its GraphQL field name at the same time caused an error
 - console: enable searching tables within a schema
 - cli: fix inherited roles metadata not being updated when dropping all roles (#7872)

server/graphql-engine.cabal

@@ -1030,6 +1030,7 @@ test-suite tests-hspec
  -- Test
     Test.ArrayRelationshipsSpec
     Test.BasicFieldsSpec
+    Test.ColumnPresetsSpec
     Test.DirectivesSpec
     Test.HelloWorldSpec
     Test.LimitOffsetSpec

server/src-lib/Hasura/Backends/MSSQL/Execute/Insert.hs

@@ -9,6 +9,7 @@ module Hasura.Backends.MSSQL.Execute.Insert
   )
 where
 
+import Data.HashMap.Strict qualified as HM
 import Database.MSSQL.Transaction qualified as Tx
 import Hasura.Backends.MSSQL.Connection
 import Hasura.Backends.MSSQL.FromIr as TSQL
@@ -181,7 +182,9 @@ buildInsertTx tableName withAlias stringifyNum insert = do
 --   Should be used as part of a bigger transaction in 'buildInsertTx'.
 buildUpsertTx :: TSQL.TableName -> AnnInsert 'MSSQL Void Expression -> IfMatched Expression -> Tx.TxET QErr IO ()
 buildUpsertTx tableName insert ifMatched = do
-  let insertColumnNames = concatMap (map fst . getInsertColumns) $ _aiInsObj $ _aiData insert
+  let presets = _aiDefVals $ _aiData insert
+      insertColumnNames =
+        concatMap (map fst . getInsertColumns) (_aiInsObj $ _aiData insert) <> HM.keys presets
       allTableColumns = _aiTableCols $ _aiData insert
       insertColumns = filter (\c -> ciColumn c `elem` insertColumnNames) allTableColumns
       createValuesTempTableQuery =

server/src-lib/Hasura/Backends/MSSQL/FromIr/Insert.hs

@@ -24,7 +24,7 @@ import Language.GraphQL.Draft.Syntax (unName)
 fromInsert :: IR.AnnInsert 'MSSQL Void Expression -> Insert
 fromInsert IR.AnnInsert {..} =
   let IR.AnnIns {..} = _aiData
-      insertRows = normalizeInsertRows $ map (IR.getInsertColumns) _aiInsObj
+      insertRows = normalizeInsertRows _aiDefVals $ map IR.getInsertColumns _aiInsObj
       insertColumnNames = maybe [] (map fst) $ listToMaybe insertRows
       insertValues = map (Values . map snd) insertRows
       allColumnNames = map (ColumnName . unName . IR.ciName) _aiTableCols
@@ -58,11 +58,13 @@ fromInsert IR.AnnInsert {..} =
 -- >   OUTPUT INSERTED.id
 -- >   VALUES (1, 'Foo', 21), (2, 'Bar', DEFAULT)
 normalizeInsertRows ::
+  HM.HashMap (Column 'MSSQL) Expression ->
   [[(Column 'MSSQL, Expression)]] ->
   [[(Column 'MSSQL, Expression)]]
-normalizeInsertRows insertRows =
-  let insertColumns = nubOrd (concatMap (map fst) insertRows)
-      allColumnsWithDefaultValue = map (,DefaultExpression) $ insertColumns
+normalizeInsertRows presets insertRows =
+  let insertColumns = nubOrd (concatMap (map fst) insertRows <> HM.keys presets)
+      allColumnsWithDefaultValue =
+        map (\col -> (col, fromMaybe DefaultExpression $ HM.lookup col presets)) insertColumns
       addMissingColumns insertRow =
         HM.toList $ HM.fromList insertRow `HM.union` HM.fromList allColumnsWithDefaultValue
       sortByColumn = sortBy (\l r -> compare (fst l) (fst r))
@@ -78,7 +80,7 @@ toMerge ::
   IfMatched Expression ->
   FromIr Merge
 toMerge tableName insertRows allColumns IfMatched {..} = do
-  let normalizedInsertRows = normalizeInsertRows $ map (IR.getInsertColumns) insertRows
+  let normalizedInsertRows = normalizeInsertRows _imColumnPresets $ map IR.getInsertColumns insertRows
       insertColumnNames = maybe [] (map fst) $ listToMaybe normalizedInsertRows
       allColumnNames = map (ColumnName . unName . IR.ciName) allColumns
 
@@ -107,7 +109,7 @@ toMerge tableName insertRows allColumns IfMatched {..} = do
 toInsertValuesIntoTempTable :: TempTableName -> IR.AnnInsert 'MSSQL Void Expression -> InsertValuesIntoTempTable
 toInsertValuesIntoTempTable tempTable IR.AnnInsert {..} =
   let IR.AnnIns {..} = _aiData
-      insertRows = normalizeInsertRows $ map IR.getInsertColumns _aiInsObj
+      insertRows = normalizeInsertRows _aiDefVals $ map IR.getInsertColumns _aiInsObj
       insertColumnNames = maybe [] (map fst) $ listToMaybe insertRows
       insertValues = map (Values . map snd) insertRows
    in InsertValuesIntoTempTable