Skip to content

Commit a9240e6

Browse files
authored
[ci] Add Wasm compilation to all_packages web app. (flutter#6981)
Adds a "--wasm" mode to create and build "all_packages" app to verify all our plugins compile with Wasm. Except not all do for now, so this also adds a "exclude_all_packages_app_wasm.yaml" file that allows us to remove the packages that aren't fully compatible yet. ## Issues * Fixes: flutter#150748 * Related: flutter#117022 * Related: flutter#148624
1 parent 62e1963 commit a9240e6

File tree

4 files changed

+35
-2
lines changed

4 files changed

+35
-2
lines changed

.ci/scripts/create_all_packages_app.sh

Lines changed: 12 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,5 +4,16 @@
44
# found in the LICENSE file.
55
set -e
66

7+
# The base exclusion file for all_packages app.
8+
exclusions=("script/configs/exclude_all_packages_app.yaml")
9+
10+
# Add a wasm-specific exclusion file if "--wasm" is specified.
11+
if [[ "$1" == "--wasm" ]]; then
12+
exclusions+=",script/configs/exclude_all_packages_app_wasm.yaml"
13+
fi
14+
15+
# Delete ./all_packages if it exists already
16+
rm -rf ./all_packages
17+
718
dart ./script/tool/bin/flutter_plugin_tools.dart create-all-packages-app \
8-
--output-dir=. --exclude script/configs/exclude_all_packages_app.yaml
19+
--output-dir=. --exclude "$exclusions"

.ci/targets/web_build_all_packages.yaml

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -10,3 +10,10 @@ tasks:
1010
- name: build all_packages app for Web release
1111
script: .ci/scripts/build_all_packages_app.sh
1212
args: ["web", "release"]
13+
- name: (Wasm) create all_packages app
14+
script: .ci/scripts/create_all_packages_app.sh
15+
args: ["--wasm"]
16+
infra_step: true # Note infra steps failing prevents "always" from running.
17+
- name: (Wasm) build all_packages app for Web release
18+
script: .ci/scripts/build_all_packages_app.sh
19+
args: ["web", "release", "--wasm"]

script/configs/exclude_all_packages_app.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,5 +9,5 @@
99
# NOTE: camera_android is semi-excluded via special casing in the repo tools.
1010
# See create_all_packages_app_command.dart.
1111

12-
# This is a permament entry, as it should never be a direct app dependency.
12+
# This is a permanent entry, as it should never be a direct app dependency.
1313
- plugin_platform_interface
Lines changed: 15 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,15 @@
1+
# This list should be kept as short as possible, and things should remain here
2+
# only as long as necessary, since in general the goal is for all of the latest
3+
# versions of packages to be mutually compatible, and compilable with Wasm.
4+
5+
# This is only used for wasm compilation. Once all packages in the repo have
6+
# been migrated, remove this file and use `exclude_all_packages_app.yaml` only.
7+
8+
# Packages that aren't migrated yet.
9+
# https://github.com/flutter/flutter/issues/117022
10+
- camera
11+
- webview_flutter
12+
13+
# Dependencies are not migrated yet
14+
# https://github.com/flutter/flutter/issues/148624
15+
- google_maps_flutter

0 commit comments

Comments
 (0)