Skip to content

Commit 568c0b7

Browse files
committed
Output the installed version of setuptools in the build log (#1007)
Since: * "explicit is better than implicit" * we'll soon be upgrading setuptools, and debugging breakage caused by upgrades will be easier if versions are visible in the build log
1 parent eb3514d commit 568c0b7

File tree

4 files changed

+14
-13
lines changed

4 files changed

+14
-13
lines changed

CHANGELOG.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22

33
# Master
44

5-
- Output the installed version of pip in the build log (#1007).
5+
- Output the installed version of pip and setuptools in the build log (#1007).
66
- Reduce the number of environment variables exposed to `bin/{pre,post}_compile` and other subprocesses (#1011)
77

88
# 173 (2020-07-21)

bin/steps/python

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -137,6 +137,7 @@ if [ ! "$SKIP_INSTALL" ]; then
137137
fi
138138

139139
PIP_VERSION='20.0.2'
140+
SETUPTOOLS_VERSION='39.0.1'
140141

141142
if [[ "${PYTHON_VERSION}" == ${PY34}* ]]; then
142143
# Python 3.4 support was dropped in pip 19.2+.
@@ -162,14 +163,14 @@ fi
162163
# If a new Python has been installed or Pip isn't up to date:
163164
if [ "$FRESH_PYTHON" ] || [[ ! $(pip --version) == *${PIP_VERSION}* ]]; then
164165

165-
puts-step "Installing pip ${PIP_VERSION}"
166+
puts-step "Installing pip ${PIP_VERSION} and setuptools ${SETUPTOOLS_VERSION}"
166167

167168
# Remove old installations.
168169
rm -fr /app/.heroku/python/lib/python*/site-packages/pip-*
169170
rm -fr /app/.heroku/python/lib/python*/site-packages/setuptools-*
170171

171172
/app/.heroku/python/bin/python "$GETPIP_PY" pip=="${PIP_VERSION}" &> /dev/null
172-
/app/.heroku/python/bin/pip install "$ROOT_DIR/vendor/setuptools-39.0.1-py2.py3-none-any.whl" &> /dev/null
173+
/app/.heroku/python/bin/pip install "$ROOT_DIR/vendor/setuptools-${SETUPTOOLS_VERSION}-py2.py3-none-any.whl" &> /dev/null
173174
fi
174175

175176
set -e

test/run-features

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,7 @@ testStandardRequirements() {
4444

4545
testPipenv() {
4646
compile "pipenv"
47-
assertCaptured "Installing pip 9.0.2"
47+
assertCaptured "Installing pip 9.0.2 and setuptools 39.0.1"
4848
assertCapturedSuccess
4949
}
5050

test/run-versions

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ testPythonDefault() {
99
compile "pythonDefault"
1010
assertCaptured $DEFAULT_PYTHON_VERSION
1111
assertNotCaptured "security update"
12-
assertCaptured "Installing pip 20.0.2"
12+
assertCaptured "Installing pip 20.0.2 and setuptools 39.0.1"
1313
assertCaptured "Installing SQLite3"
1414
assertCapturedSuccess
1515
}
@@ -25,7 +25,7 @@ testPython2() {
2525
assertNotCaptured "python-2-7-eol-faq";
2626
fi
2727
assertNotCaptured "security update"
28-
assertCaptured "Installing pip 20.0.2"
28+
assertCaptured "Installing pip 20.0.2 and setuptools 39.0.1"
2929
assertCaptured "Installing SQLite3"
3030
assertCapturedSuccess
3131
}
@@ -53,7 +53,7 @@ testPython3_4() {
5353
compile "python3_4"
5454
assertCaptured $LATEST_34
5555
assertNotCaptured "security update"
56-
assertCaptured "Installing pip 19.1.1"
56+
assertCaptured "Installing pip 19.1.1 and setuptools 39.0.1"
5757
# if cedar 14 and legacy binaries, fail. if cedar 14 and staging, succeed.
5858
if [[ ! -n $USE_STAGING_BINARIES ]] && [[ $STACK == "cedar-14" ]]; then
5959
assertCapturedError
@@ -89,7 +89,7 @@ testPython3_5() {
8989
compile "python3_5"
9090
assertCaptured $LATEST_35
9191
assertNotCaptured "security update"
92-
assertCaptured "Installing pip 20.0.2"
92+
assertCaptured "Installing pip 20.0.2 and setuptools 39.0.1"
9393
assertCaptured "Installing SQLite3"
9494
assertCapturedSuccess
9595
}
@@ -112,7 +112,7 @@ testPython3_6() {
112112
compile "python3_6"
113113
assertCaptured $LATEST_36
114114
assertNotCaptured "security update"
115-
assertCaptured "Installing pip 20.0.2"
115+
assertCaptured "Installing pip 20.0.2 and setuptools 39.0.1"
116116
assertCaptured "Installing SQLite3"
117117
assertCapturedSuccess
118118
}
@@ -139,7 +139,7 @@ testPython3_7() {
139139
else
140140
assertNotCaptured "security update"
141141
assertCaptured $LATEST_37
142-
assertCaptured "Installing pip 20.0.2"
142+
assertCaptured "Installing pip 20.0.2 and setuptools 39.0.1"
143143
assertCaptured "Installing SQLite3"
144144
assertCapturedSuccess
145145
fi
@@ -183,7 +183,7 @@ testPython3_8() {
183183
else
184184
assertNotCaptured "security update"
185185
assertCaptured $LATEST_38
186-
assertCaptured "Installing pip 20.0.2"
186+
assertCaptured "Installing pip 20.0.2 and setuptools 39.0.1"
187187
assertCaptured "Installing SQLite3"
188188
assertCapturedSuccess
189189
fi
@@ -202,7 +202,7 @@ testPypy3_6() {
202202
else
203203
assertCaptured "Installing pypy"
204204
assertCaptured "$PYPY_36"
205-
assertCaptured "Installing pip 20.0.2"
205+
assertCaptured "Installing pip 20.0.2 and setuptools 39.0.1"
206206
assertCapturedSuccess
207207
fi
208208
}
@@ -214,7 +214,7 @@ testPypy2_7() {
214214
else
215215
assertCaptured "Installing pypy"
216216
assertCaptured "$PYPY_27"
217-
assertCaptured "Installing pip 20.0.2"
217+
assertCaptured "Installing pip 20.0.2 and setuptools 39.0.1"
218218
assertCapturedSuccess
219219
fi
220220
}

0 commit comments

Comments
 (0)