Skip to content

Commit e54fad8

Browse files
zhengbin13gregkh
authored andcommitted
slimbus: qcom-ngd: Fix build error when CONFIG_SLIM_QCOM_NGD_CTRL=y && CONFIG_QCOM_RPROC_COMMON=m
If CONFIG_SLIM_QCOM_NGD_CTRL=y, CONFIG_QCOM_RPROC_COMMON=m, COMPILE_TEST=y, bulding fails: drivers/slimbus/qcom-ngd-ctrl.o: In function `qcom_slim_ngd_ctrl_probe': qcom-ngd-ctrl.c:(.text+0x330): undefined reference to `qcom_register_ssr_notifier' qcom-ngd-ctrl.c:(.text+0x5fc): undefined reference to `qcom_unregister_ssr_notifier' drivers/slimbus/qcom-ngd-ctrl.o: In function `qcom_slim_ngd_remove': qcom-ngd-ctrl.c:(.text+0x90c): undefined reference to `qcom_unregister_ssr_notifier' Make SLIM_QCOM_NGD_CTRL depends on QCOM_RPROC_COMMON || (COMPILE_TEST && !QCOM_RPROC_COMMON) to fix this. Fixes: e291691 ("slimbus: qcom-ngd-ctrl: allow compile testing without QCOM_RPROC_COMMON") Cc: stable <[email protected]> Signed-off-by: Zheng Bin <[email protected]> Reviewed-by: Krzysztof Kozlowski <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Greg Kroah-Hartman <[email protected]>
1 parent 5fddf89 commit e54fad8

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

drivers/slimbus/Kconfig

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@ config SLIM_QCOM_CTRL
2323
config SLIM_QCOM_NGD_CTRL
2424
tristate "Qualcomm SLIMbus Satellite Non-Generic Device Component"
2525
depends on HAS_IOMEM && DMA_ENGINE && NET
26-
depends on QCOM_RPROC_COMMON || COMPILE_TEST
26+
depends on QCOM_RPROC_COMMON || (COMPILE_TEST && !QCOM_RPROC_COMMON)
2727
depends on ARCH_QCOM || COMPILE_TEST
2828
select QCOM_QMI_HELPERS
2929
select QCOM_PDR_HELPERS

0 commit comments

Comments
 (0)