Merge pull request #2081 from hey-api/fix/parser-3-1-0-exclusive-limits

fix(parser): handle exclusiveMinimum and exclusiveMaximum in OpenAPI 3.1.x when they're 0

Author: mrlubos

.changeset/hip-crabs-help.md

@@ -8,9 +8,7 @@ feat: upgraded input filters
 
 Input filters now avoid generating invalid output without requiring you to specify every missing schema as in the previous releases. As part of this release, we changed the way filters are configured and removed the support for regular expressions. Let us know if regular expressions are still useful for you and want to bring them back!
 
-::: code-group
-
-```js [include]
+```js
 export default {
   input: {
     // match only the schema named `foo` and `GET` operation for the `/api/v1/foo` path
@@ -29,25 +27,3 @@ export default {
   plugins: ['@hey-api/client-fetch'],
 };
 ```
-
-```js [exclude]
-export default {
-  input: {
-    // match everything except for the schema named `foo` and `GET` operation for the `/api/v1/foo` path
-    exclude: '^(#/components/schemas/foo|#/paths/api/v1/foo/get)$', // [!code --]
-    filters: {
-      operations: {
-        exclude: ['GET /api/v1/foo'], // [!code ++]
-      },
-      schemas: {
-        exclude: ['foo'], // [!code ++]
-      },
-    },
-    path: 'https://get.heyapi.dev/hey-api/backend',
-  },
-  output: 'src/client',
-  plugins: ['@hey-api/client-fetch'],
-};
-```
-
-:::

.changeset/moody-socks-develop.md

@@ -0,0 +1,5 @@
+---
+'@hey-api/openapi-ts': patch
+---
+
+fix(parser): handle exclusiveMinimum and exclusiveMaximum in OpenAPI 3.1.x when they're 0

packages/openapi-ts-tests/test/__snapshots__/3.0.x/validators/valibot.gen.ts

@@ -15,7 +15,7 @@ export const vFoo: v.GenericSchema = v.optional(v.union([
         baz: v.optional(v.array(v.lazy(() => {
             return vFoo;
         }))),
-        qux: v.optional(v.number(), 0)
+        qux: v.optional(v.pipe(v.number(), v.integer(), v.gtValue(0)), 0)
     }),
     v.null()
 ]), null);

packages/openapi-ts-tests/test/__snapshots__/3.0.x/validators/zod.gen.ts

@@ -15,7 +15,7 @@ export const zFoo: z.ZodTypeAny = z.union([
         baz: z.array(z.lazy(() => {
             return zFoo;
         })).optional(),
-        qux: z.number().optional().default(0)
+        qux: z.number().int().gt(0).optional().default(0)
     }),
     z.null()
 ]).default(null);

packages/openapi-ts-tests/test/__snapshots__/3.1.x/validators/valibot.gen.ts

@@ -15,7 +15,7 @@ export const vFoo: v.GenericSchema = v.optional(v.union([
         baz: v.optional(v.array(v.lazy(() => {
             return vFoo;
         }))),
-        qux: v.optional(v.number(), 0)
+        qux: v.optional(v.pipe(v.number(), v.integer(), v.gtValue(0)), 0)
     }),
     v.null()
 ]), null);

packages/openapi-ts-tests/test/__snapshots__/3.1.x/validators/zod.gen.ts

@@ -15,7 +15,7 @@ export const zFoo: z.ZodTypeAny = z.union([
         baz: z.array(z.lazy(() => {
             return zFoo;
         })).optional(),
-        qux: z.number().optional().default(0)
+        qux: z.number().int().gt(0).optional().default(0)
     }),
     z.null()
 ]).default(null);

packages/openapi-ts-tests/test/openapi-ts.config.ts

@@ -22,11 +22,11 @@ export default defineConfig(() => {
       //   },
       // },
       filters: {
-        deprecated: false,
+        // deprecated: false,
         // operations: {
         //   include: ['POST /foo'],
         // },
-        orphans: false,
+        // orphans: false,
         // preserveOrder: true,
         // tags: {
         //   exclude: ['bar'],
@@ -41,7 +41,7 @@ export default defineConfig(() => {
       //   openapi: '3.1.0',
       //   paths: {},
       // },
-      path: path.resolve(__dirname, 'spec', '3.1.x', 'full.json'),
+      path: path.resolve(__dirname, 'spec', '3.1.x', 'validators.json'),
       // path: 'http://localhost:4000/',
       // path: 'https://get.heyapi.dev/',
       // path: 'https://get.heyapi.dev/hey-api/backend?branch=main&version=1.0.0',

packages/openapi-ts-tests/test/spec/3.0.x/validators.json

@@ -25,7 +25,9 @@
           },
           "qux": {
             "default": 0,
-            "type": "number"
+            "exclusiveMinimum": true,
+            "minimum": 0,
+            "type": "integer"
           }
         },
         "type": "object"

packages/openapi-ts-tests/test/spec/3.1.x/validators.json

@@ -24,7 +24,8 @@
           },
           "qux": {
             "default": 0,
-            "type": "number"
+            "exclusiveMinimum": 0,
+            "type": "integer"
           }
         },
         "type": ["object", "null"]

packages/openapi-ts/src/openApi/3.1.x/parser/schema.ts

@@ -88,11 +88,11 @@ const parseSchemaMeta = ({
     irSchema.default = schema.default;
   }
 
-  if (schema.exclusiveMaximum) {
+  if (schema.exclusiveMaximum !== undefined) {
     irSchema.exclusiveMaximum = schema.exclusiveMaximum;
   }
 
-  if (schema.exclusiveMinimum) {
+  if (schema.exclusiveMinimum !== undefined) {
     irSchema.exclusiveMinimum = schema.exclusiveMinimum;
   }