use Objects.requireNonNull in generated code for repositories

instead of directly throwing IllegalArgumentException

Author: gavinking

Diff for: tooling/metamodel-generator/src/main/java/org/hibernate/processor/annotation/AbstractAnnotatedMethod.java

@@ -17,6 +17,7 @@
 import static org.hibernate.processor.annotation.AnnotationMetaEntity.usingReactiveSessionAccess;
 import static org.hibernate.processor.annotation.AnnotationMetaEntity.usingStatelessSession;
 import static org.hibernate.processor.util.Constants.ENTITY_MANAGER;
+import static org.hibernate.processor.util.Constants.OBJECTS;
 import static org.hibernate.processor.util.TypeUtils.hasAnnotation;
 
 /**
@@ -76,4 +77,15 @@ public List<AnnotationMirror> inheritedAnnotations() {
 			return emptyList();
 		}
 	}
+
+	void nullCheck(StringBuilder declaration, String paramName) {
+		declaration
+				.append('\t')
+				.append(annotationMetaEntity.staticImport(OBJECTS, "requireNonNull"))
+				.append('(')
+				.append(paramName.replace('.', '$'))
+				.append(", \"Null ")
+				.append(paramName)
+				.append("\");\n");
+	}
 }

Diff for: tooling/metamodel-generator/src/main/java/org/hibernate/processor/annotation/AbstractCriteriaMethod.java

@@ -114,15 +114,6 @@ void nullChecks(List<String> paramTypes, StringBuilder declaration) {
 		}
 	}
 
-	private static void nullCheck(StringBuilder declaration, String paramName) {
-		declaration
-				.append("\tif (")
-				.append(paramName.replace('.', '$'))
-				.append(" == null) throw new IllegalArgumentException(\"Null ")
-				.append(paramName)
-				.append("\");\n");
-	}
-
 	void where(StringBuilder declaration, List<String> paramTypes) {
 		declaration
 				.append("\t_query.where(");

Diff for: tooling/metamodel-generator/src/main/java/org/hibernate/processor/annotation/IdFinderMethod.java

@@ -180,13 +180,4 @@ private void findWithNoFetchProfiles(StringBuilder declaration) {
 		declaration
 				.append(")");
 	}
-
-	private static void nullCheck(StringBuilder declaration, String parameterName) {
-		declaration
-				.append("\tif (")
-				.append(parameterName)
-				.append(" == null) throw new IllegalArgumentException(\"Null ")
-				.append(parameterName)
-				.append("\");\n");
-	}
 }

Diff for: tooling/metamodel-generator/src/main/java/org/hibernate/processor/annotation/LifecycleMethod.java

@@ -56,7 +56,7 @@ public boolean hasStringAttribute() {
 	public String getAttributeDeclarationString() {
 		StringBuilder declaration = new StringBuilder();
 		preamble(declaration);
-		nullCheck(declaration);
+		nullCheck(declaration, parameterName);
 		declaration.append("\ttry {\n");
 		delegateCall(declaration);
 		returnArgument(declaration);
@@ -194,15 +194,6 @@ private String returnType() {
 		}
 	}
 
-	private void nullCheck(StringBuilder declaration) {
-		declaration
-				.append("\tif (")
-				.append(parameterName)
-				.append(" == null) throw new IllegalArgumentException(\"Null ")
-				.append(parameterName)
-				.append("\");\n");
-	}
-
 	private void convertException(StringBuilder declaration, String exception, String convertedException) {
 		declaration
 				.append("\tcatch (")

Diff for: tooling/metamodel-generator/src/main/java/org/hibernate/processor/util/Constants.java

@@ -123,6 +123,7 @@ public final class Constants {
 	public static final String MAP_ATTRIBUTE = "jakarta.persistence.metamodel.MapAttribute";
 
 	public static final String JAVA_OBJECT = "java.lang.Object";
+	public static final String OBJECTS = "java.util.Objects";
 	public static final String ITERABLE = "java.lang.Iterable";
 	public static final String COLLECTION = "java.util.Collection";
 	public static final String LIST = "java.util.List";