chore: remove some warnings from tests

Replace assertions

Author: DavideD

hibernate-reactive-core/src/test/java/org/hibernate/reactive/JoinedSubclassInheritanceTest.java

@@ -5,11 +5,6 @@
  */
 package org.hibernate.reactive;
 
-import java.util.Collection;
-import java.util.Date;
-import java.util.List;
-import java.util.Objects;
-
 import org.junit.jupiter.api.Assertions;
 import org.junit.jupiter.api.Test;
 
@@ -26,12 +21,13 @@
 import jakarta.persistence.Table;
 import jakarta.persistence.Temporal;
 import jakarta.persistence.TemporalType;
+import java.util.Collection;
+import java.util.Date;
+import java.util.List;
+import java.util.Objects;
 
 import static java.util.concurrent.TimeUnit.MINUTES;
-import static org.junit.jupiter.api.Assertions.assertEquals;
-import static org.junit.jupiter.api.Assertions.assertFalse;
-import static org.junit.jupiter.api.Assertions.assertNotNull;
-import static org.junit.jupiter.api.Assertions.assertTrue;
+import static org.assertj.core.api.Assertions.assertThat;
 
 @Timeout(value = 10, timeUnit = MINUTES)
 
@@ -56,9 +52,8 @@ public void testRootClassViaAssociation(VertxTestContext context) {
 								.thenCompose( v -> openSession() )
 								.thenCompose( s2 -> s2.find( Author.class, author.getId() ) )
 								.thenAccept( auth -> {
-									assertNotNull( auth );
-									assertEquals( author, auth );
-									assertEquals( book.getTitle(), auth.getBook().getTitle()  );
+									assertThat( auth ).isEqualTo( author );
+									assertThat( auth.getBook().getTitle() ).isEqualTo( book.getTitle() );
 								} )
 				)
 		);
@@ -77,17 +72,15 @@ public void testSubclassViaAssociation(VertxTestContext context) {
 								.thenCompose( v -> s.flush() )
 								.thenCompose( v -> s.find( Author.class, author.getId() ) )
 								.thenAccept( auth -> {
-									assertNotNull( auth );
-									assertEquals( author, auth );
-									assertEquals( book.getTitle(), auth.getBook().getTitle()  );
+									assertThat( auth ).isEqualTo( author );
+									assertThat( auth.getBook().getTitle() ).isEqualTo( book.getTitle() );
 								} )
 				)
 		);
 	}
 
 	@Test
 	public void testRootClassViaFind(VertxTestContext context) {
-
 		final Book novel = new Book( 6, "The Boy, The Mole, The Fox and The Horse", new Date());
 		final Author author = new Author( "Charlie Mackesy", novel );
 
@@ -99,9 +92,8 @@ public void testRootClassViaFind(VertxTestContext context) {
 						.thenCompose( v -> openSession()
 								.thenCompose( s -> s.find(Book.class, 6) ) )
 						.thenAccept(book -> {
-							assertNotNull(book);
-							assertFalse(book instanceof SpellBook);
-							assertEquals(book.getTitle(), "The Boy, The Mole, The Fox and The Horse");
+							assertThat( book ).isNotInstanceOf( SpellBook.class );
+							assertThat( book.getTitle() ).isEqualTo( "The Boy, The Mole, The Fox and The Horse" );
 						}));
 	}
 
@@ -117,35 +109,41 @@ public void testSubclassViaFind(VertxTestContext context) {
 								.thenCompose( v -> s.flush() ) )
 						.thenCompose( v -> openSession().thenCompose( s -> s.find(Book.class, 6) ) )
 						.thenAccept(book -> {
-							assertNotNull(book);
-							assertTrue(book instanceof SpellBook);
-							assertEquals(book.getTitle(), "Necronomicon");
+							assertThat( book ).isInstanceOf( SpellBook.class );
+							assertThat( book.getTitle() ).isEqualTo( "Necronomicon" );
 						}));
 	}
 
 	@Test
 	public void testQueryUpdate(VertxTestContext context) {
 		final SpellBook spells = new SpellBook( 6, "Necronomicon", true, new Date() );
-//		final Author author = new Author( "Abdul Alhazred", spells );
 
-		test( context,
+		test(
+				context,
 				openSession()
-						.thenCompose( s -> s.persist(spells).thenCompose( v -> s.flush() ) )
+						.thenCompose( s -> s.persist( spells ).thenCompose( v -> s.flush() ) )
 						.thenCompose( vv -> openSession()
-								.thenCompose( s -> s.withTransaction( t -> s.createMutationQuery("update SpellBook set title='x' where forbidden=false").executeUpdate() )
-										.thenCompose( v -> s.withTransaction( t -> s.createMutationQuery("update SpellBook set forbidden=false where title='Necronomicon'").executeUpdate() ) )
-										.thenCompose( v -> s.withTransaction( t -> s.createMutationQuery("update Book set title=title||' II' where title='Necronomicon'").executeUpdate() ) )
-										.thenCompose( v -> s.find(Book.class, 6) )
+								.thenCompose( s -> s.withTransaction( t -> s
+												.createMutationQuery( "update SpellBook set title='x' where forbidden=false" )
+												.executeUpdate() )
+										.thenCompose( v -> s.withTransaction( t -> s
+												.createMutationQuery( "update SpellBook set forbidden=false where title='Necronomicon'" )
+												.executeUpdate() ) )
+										.thenCompose( v -> s.withTransaction( t -> s
+												.createMutationQuery( "update Book set title=title||' II' where title='Necronomicon'" )
+												.executeUpdate() ) )
+										.thenCompose( v -> s.find( Book.class, 6 ) )
 										.thenAccept( book -> {
-											assertNotNull(book);
-											assertTrue(book instanceof SpellBook);
-											assertEquals(book.getTitle(), "Necronomicon II");
+											assertThat( book ).isInstanceOf( SpellBook.class );
+											assertThat( book.getTitle() ).isEqualTo( "Necronomicon II" );
 										} )
-						) )
+								) )
 						.thenCompose( vv -> openSession()
-								.thenCompose( s -> s.withTransaction( t -> s.createMutationQuery("delete Book where title='Necronomicon II'").executeUpdate() ) )
+								.thenCompose( s -> s.withTransaction( t -> s
+										.createMutationQuery( "delete Book where title='Necronomicon II'" )
+										.executeUpdate() ) )
 								.thenCompose( v -> openSession() )
-								.thenCompose( s -> s.find(Book.class, 6) )
+								.thenCompose( s -> s.find( Book.class, 6 ) )
 								.thenAccept( Assertions::assertNull )
 						)
 		);
@@ -154,7 +152,6 @@ public void testQueryUpdate(VertxTestContext context) {
 	@Test
 	public void testQueryUpdateWithParameters(VertxTestContext context) {
 		final SpellBook spells = new SpellBook( 6, "Necronomicon", true, new Date() );
-//		final Author author = new Author( "Abdul Alhazred", spells );
 
 		test( context,
 				openSession()
@@ -174,11 +171,9 @@ public void testQueryUpdateWithParameters(VertxTestContext context) {
 						.thenCompose( v -> openSession()
 								.thenCompose( s -> s.find( Book.class, 6) )
 								.thenAccept( book -> {
-											assertNotNull(book);
-											assertTrue(book instanceof SpellBook);
-											assertEquals(book.getTitle(), "Necronomicon II");
-										}
-								)
+									assertThat( book ).isInstanceOf( SpellBook.class );
+									assertThat( book.getTitle() ).isEqualTo( "Necronomicon II" );
+								} )
 						)
 						.thenCompose( v -> openSession()
 								.thenCompose( s -> s.withTransaction( t -> s.createMutationQuery("delete Book where title=:tit")
@@ -207,6 +202,11 @@ public SpellBook(Integer id, String title, boolean forbidden, Date published) {
 		public boolean getForbidden() {
 			return forbidden;
 		}
+
+		@Override
+		public String toString() {
+			return "SpellBook{" + super.toString() + ",forbidden=" + forbidden + '}';
+		}
 	}
 
 	@Entity(name="Book")
@@ -268,6 +268,11 @@ public boolean equals(Object o) {
 		public int hashCode() {
 			return Objects.hash( title );
 		}
+
+		@Override
+		public String toString() {
+			return id + ", " + title + ", " + published;
+		}
 	}
 
 	@Entity(name = "Author")