Skip to content

Commit a8db9cd

Browse files
gunnarmorlinggsmet
authored andcommitted
HV-1266 Updating build instructions to reflect relocation of @generated
1 parent 8e717e4 commit a8db9cd

File tree

2 files changed

+12
-3
lines changed

2 files changed

+12
-3
lines changed

README.md

+2-2
Original file line numberDiff line numberDiff line change
@@ -84,13 +84,13 @@ There are more build options available as well. For more information refer to [C
8484

8585
To build Hibernate Validator with JDK 9, export the following environment variable:
8686

87-
export MAVEN_OPTS="--add-modules java.annotations.common,java.xml.bind --add-opens=java.base/java.security=ALL-UNNAMED --add-opens=java.base/java.lang=ALL-UNNAMED --add-opens=java.base/java.util=ALL-UNNAMED"
87+
export MAVEN_OPTS="--add-opens=java.base/java.security=ALL-UNNAMED --add-opens=java.base/java.lang=ALL-UNNAMED"
8888

8989
Then the build can be started like this:
9090

9191
mvn -s settings-example.xml clean install
9292

93-
Also the OSGi integration tests will fail on Java 9 currently, hence the "osgi" module is excluded automatically when building on JDK 9. We are waiting for the release of Karaf 4.1.0.
93+
Also the OSGi integration tests will fail on Java 9 currently, hence the "osgi" module is excluded automatically when building on JDK 9. We are waiting for the release of a Karaf version supporting the latest Java 9 builds.
9494

9595
Here are the reasons why we added the various --add-opens options:
9696

pom.xml

+10-1
Original file line numberDiff line numberDiff line change
@@ -392,7 +392,7 @@
392392
</plugin>
393393
<plugin>
394394
<artifactId>maven-compiler-plugin</artifactId>
395-
<version>3.5.1</version>
395+
<version>3.6.1</version>
396396
<configuration>
397397
<testCompilerArgument>-parameters</testCompilerArgument>
398398
</configuration>
@@ -924,6 +924,15 @@
924924
<build>
925925
<pluginManagement>
926926
<plugins>
927+
<plugin>
928+
<artifactId>maven-compiler-plugin</artifactId>
929+
<configuration>
930+
<fork>true</fork>
931+
<compilerArgs>
932+
<arg>-J--add-modules=java.xml.ws.annotation</arg>
933+
</compilerArgs>
934+
</configuration>
935+
</plugin>
927936
<plugin>
928937
<artifactId>maven-surefire-plugin</artifactId>
929938
<version>${maven-surefire-plugin.version}</version>

0 commit comments

Comments
 (0)