Skip to content

Commit 4363e97

Browse files
committed
Resolve lgtm warning
1 parent f954fa9 commit 4363e97

File tree

3 files changed

+5
-5
lines changed

3 files changed

+5
-5
lines changed

examples/src/main/java/com/hivemq/client/mqtt/examples/ReconnectStrategy.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -73,7 +73,7 @@ private static void completelyCustom() {
7373
.addDisconnectedListener(context -> {
7474
context.getReconnector()
7575
.reconnect(true) // always reconnect (includes calling disconnect)
76-
.delay(2 * context.getReconnector().getAttempts(), TimeUnit.SECONDS); // linear scaling delay
76+
.delay(2L * context.getReconnector().getAttempts(), TimeUnit.SECONDS); // linear scaling delay
7777
})
7878
// multiple DisconnectedListener can form a reconnect strategy
7979
.addDisconnectedListener(context -> {

src/main/java/com/hivemq/client/internal/mqtt/datatypes/MqttVariableByteInteger.java

+2-2
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@ public final class MqttVariableByteInteger {
3232
public static final int NOT_MINIMUM_BYTES = -3;
3333
private static final int CONTINUATION_BIT_MASK = 0x80;
3434
private static final int VALUE_MASK = 0x7f;
35-
private static final int VALUE_BITS = 7;
35+
private static final byte VALUE_BITS = 7;
3636
private static final int MAX_SHIFT = VALUE_BITS * 3;
3737
private static final int ONE_BYTE_MAX_VALUE = (1 << VALUE_BITS) - 1;
3838
private static final int TWO_BYTES_MAX_VALUE = (1 << (VALUE_BITS * 2)) - 1;
@@ -87,7 +87,7 @@ public static int decode(final @NotNull ByteBuf byteBuf) {
8787
public static void encode(int value, final @NotNull ByteBuf byteBuf) {
8888
do {
8989
int encodedByte = value & VALUE_MASK;
90-
value >>>= 7;
90+
value >>>= VALUE_BITS;
9191
if (value > 0) {
9292
encodedByte |= CONTINUATION_BIT_MASK;
9393
}

src/main/java/com/hivemq/client/internal/mqtt/handler/publish/outgoing/MqttTopicAliasAutoMapping.java

+2-2
Original file line numberDiff line numberDiff line change
@@ -100,7 +100,7 @@ public int onPublish(final @NotNull MqttTopicImpl topic) {
100100
}
101101
fullOverwriteTries = 0;
102102
if (fullOverwriteCost < OVERWRITE_COST_MAX) {
103-
fullOverwriteCost += Math.min(OVERWRITE_COST_INC, OVERWRITE_COST_MAX - fullOverwriteCost);
103+
fullOverwriteCost += (byte) Math.min(OVERWRITE_COST_INC, OVERWRITE_COST_MAX - fullOverwriteCost);
104104
}
105105
if (lowest.topicAlias != DEFAULT_NO_TOPIC_ALIAS) {
106106
newEntry.setNewTopicAlias(lowest.topicAlias);
@@ -136,7 +136,7 @@ private void swapNewer(final @NotNull Entry entry, final long accessCounter) {
136136
}
137137
overwriteTries = 0;
138138
if (overwriteCost < OVERWRITE_COST_MAX) {
139-
overwriteCost += Math.min(OVERWRITE_COST_INC, OVERWRITE_COST_MAX - overwriteCost);
139+
overwriteCost += (byte) Math.min(OVERWRITE_COST_INC, OVERWRITE_COST_MAX - overwriteCost);
140140
}
141141
entry.setNewTopicAlias(higher.topicAlias);
142142
higher.topicAlias = DEFAULT_NO_TOPIC_ALIAS;

0 commit comments

Comments
 (0)