Removed unnecessary test implementation, use mocks

Author: SgtSilvio

src/test/java/com/hivemq/client/internal/mqtt/datatypes/MqttUserPropertiesImplBuilderTest.java

@@ -23,12 +23,12 @@
 import com.hivemq.client.mqtt.mqtt5.datatypes.Mqtt5UserProperty;
 import org.jetbrains.annotations.NotNull;
 import org.junit.jupiter.api.Test;
-import util.implementations.CustomUserProperty;
 
 import java.util.*;
 import java.util.stream.Stream;
 
 import static org.junit.jupiter.api.Assertions.*;
+import static org.mockito.Mockito.mock;
 
 /**
  * @author Michael Walter
@@ -49,7 +49,7 @@ void addAll_error_when_one_element_is_custom_implementation() {
 
         final List<Mqtt5UserProperty> userProperties = new ArrayList<>();
         userProperties.add(userProperty);
-        userProperties.add(new CustomUserProperty());
+        userProperties.add(mock(Mqtt5UserProperty.class));
 
         final Mqtt5UserPropertiesBuilder userPropertiesBuilder = Mqtt5UserProperties.builder();
 

src/test/java/com/hivemq/client/internal/mqtt/message/subscribe/MqttSubscribeBuilderTest.java

@@ -25,12 +25,12 @@
 import com.hivemq.client.mqtt.mqtt5.message.subscribe.Mqtt5Subscription;
 import org.jetbrains.annotations.NotNull;
 import org.junit.jupiter.api.Test;
-import util.implementations.CustomMqtt5Subscription;
 
 import java.util.*;
 import java.util.stream.Stream;
 
 import static org.junit.jupiter.api.Assertions.*;
+import static org.mockito.Mockito.mock;
 
 /**
  * @author Michael Walter
@@ -46,7 +46,7 @@ void addSubscription_error_when_subscription_is_null() {
     void addSubscription_error_when_subscription_is_implemented() {
         assertThrows(
                 IllegalArgumentException.class,
-                () -> Mqtt5Subscribe.builder().addSubscription(new CustomMqtt5Subscription()));
+                () -> Mqtt5Subscribe.builder().addSubscription(mock(Mqtt5Subscription.class)));
     }
 
     @Test
@@ -176,7 +176,7 @@ void addSubscriptions_error_when_subscription_is_implemented() {
 
         final List<Mqtt5Subscription> subscriptions = new ArrayList<>();
         subscriptions.add(subscription);
-        subscriptions.add(new CustomMqtt5Subscription());
+        subscriptions.add(mock(Mqtt5Subscription.class));
 
         final Mqtt5SubscribeBuilder.Complete builder = Mqtt5Subscribe.builder().topicFilter("first");
         assertThrows(IllegalArgumentException.class, () -> builder.addSubscriptions(subscriptions));

src/test/java/com/hivemq/client/internal/mqtt/message/subscribe/mqtt3/Mqtt3SubscribeViewBuilderTest.java

@@ -24,12 +24,12 @@
 import com.hivemq.client.mqtt.mqtt3.message.subscribe.Mqtt3Subscription;
 import org.jetbrains.annotations.NotNull;
 import org.junit.jupiter.api.Test;
-import util.implementations.CustomMqtt3Subscription;
 
 import java.util.*;
 import java.util.stream.Stream;
 
 import static org.junit.jupiter.api.Assertions.*;
+import static org.mockito.Mockito.mock;
 
 /**
  * @author Michael Walter
@@ -45,7 +45,7 @@ void addSubscription_error_when_subscription_is_null() {
     void addSubscription_error_when_subscription_is_implemented() {
         assertThrows(
                 IllegalArgumentException.class,
-                () -> Mqtt3Subscribe.builder().addSubscription(new CustomMqtt3Subscription()));
+                () -> Mqtt3Subscribe.builder().addSubscription(mock(Mqtt3Subscription.class)));
     }
 
     @Test
@@ -164,7 +164,7 @@ void addSubscriptions_error_when_subscription_is_implemented() {
 
         final List<Mqtt3Subscription> subscriptions = new ArrayList<>();
         subscriptions.add(subscription);
-        subscriptions.add(new CustomMqtt3Subscription());
+        subscriptions.add(mock(Mqtt3Subscription.class));
 
         final Mqtt3SubscribeBuilder.Complete builder = Mqtt3Subscribe.builder().topicFilter("first");
         assertThrows(IllegalArgumentException.class, () -> builder.addSubscriptions(subscriptions));

src/test/java/com/hivemq/client/internal/mqtt/message/unsubscribe/MqttUnsubscribeBuilderTest.java

@@ -21,14 +21,14 @@
 import com.hivemq.client.mqtt.datatypes.MqttTopicFilter;
 import com.hivemq.client.mqtt.mqtt5.message.unsubscribe.Mqtt5Unsubscribe;
 import org.junit.jupiter.api.Test;
-import util.implementations.CustomMqttTopicFilter;
 
 import java.util.ArrayList;
 import java.util.List;
 import java.util.stream.Stream;
 
 import static org.junit.jupiter.api.Assertions.assertEquals;
 import static org.junit.jupiter.api.Assertions.assertThrows;
+import static org.mockito.Mockito.mock;
 
 /**
  * @author Michael Walter
@@ -50,7 +50,7 @@ void addTopicFilter_error_when_mqtt_topic_is_null() {
     @Test
     void addTopicFilter_error_when_topic_object_is_implemented() {
         assertThrows(IllegalArgumentException.class,
-                () -> Mqtt5Unsubscribe.builder().addTopicFilter(new CustomMqttTopicFilter()));
+                () -> Mqtt5Unsubscribe.builder().addTopicFilter(mock(MqttTopicFilter.class)));
     }
 
     @Test
@@ -325,7 +325,11 @@ void addTopicFilters_nested_topic_builder_is_used_and_then_addTopicFilters() {
 
         final Mqtt5Unsubscribe subscribe = Mqtt5Unsubscribe.builder()
                 .topicFilter()
-                .addLevel("first").addLevel("second").multiLevelWildcard().applyTopicFilter().addTopicFilters(topics)
+                .addLevel("first")
+                .addLevel("second")
+                .multiLevelWildcard()
+                .applyTopicFilter()
+                .addTopicFilters(topics)
                 .build();
 
         final List<? extends MqttTopicFilter> unsubscribeTopics = subscribe.getTopicFilters();
@@ -366,7 +370,7 @@ void addTopicFilters_fluent_topic_is_finished_if_addTopicFilters_is_used_second_
     void addTopicFilters_error_when_topic_object_is_implemented() {
 
         final ImmutableList<MqttTopicFilter> topicFilters =
-                ImmutableList.of(MqttTopicFilter.of("test"), new CustomMqttTopicFilter());
+                ImmutableList.of(MqttTopicFilter.of("test"), mock(MqttTopicFilter.class));
 
         assertThrows(IllegalArgumentException.class, () -> Mqtt5Unsubscribe.builder().addTopicFilters(topicFilters));
     }

src/test/java/com/hivemq/client/internal/mqtt/message/unsubscribe/mqtt3/Mqtt3UnsubscribeViewBuilderTest.java

@@ -21,14 +21,14 @@
 import com.hivemq.client.mqtt.datatypes.MqttTopicFilter;
 import com.hivemq.client.mqtt.mqtt3.message.unsubscribe.Mqtt3Unsubscribe;
 import org.junit.jupiter.api.Test;
-import util.implementations.CustomMqttTopicFilter;
 
 import java.util.ArrayList;
 import java.util.List;
 import java.util.stream.Stream;
 
 import static org.junit.jupiter.api.Assertions.assertEquals;
 import static org.junit.jupiter.api.Assertions.assertThrows;
+import static org.mockito.Mockito.mock;
 
 /**
  * @author Michael Walter
@@ -50,7 +50,7 @@ void addTopicFilter_error_when_mqtt_topic_is_null() {
     @Test
     void addTopicFilter_error_when_topic_object_is_implemented() {
         assertThrows(IllegalArgumentException.class,
-                () -> Mqtt3Unsubscribe.builder().addTopicFilter(new CustomMqttTopicFilter()));
+                () -> Mqtt3Unsubscribe.builder().addTopicFilter(mock(MqttTopicFilter.class)));
     }
 
     @Test
@@ -325,7 +325,11 @@ void addTopicFilters_nested_topic_builder_is_used_and_then_addTopicFilters() {
 
         final Mqtt3Unsubscribe subscribe = Mqtt3Unsubscribe.builder()
                 .topicFilter()
-                .addLevel("first").addLevel("second").multiLevelWildcard().applyTopicFilter().addTopicFilters(topics)
+                .addLevel("first")
+                .addLevel("second")
+                .multiLevelWildcard()
+                .applyTopicFilter()
+                .addTopicFilters(topics)
                 .build();
 
         final List<? extends MqttTopicFilter> unsubscribeTopics = subscribe.getTopicFilters();
@@ -366,7 +370,7 @@ void addTopicFilters_fluent_topic_is_finished_if_addTopicFilters_is_used_second_
     void addTopicFilters_error_when_topic_object_is_implemented() {
 
         final ImmutableList<MqttTopicFilter> topicFilters =
-                ImmutableList.of(MqttTopicFilter.of("test"), new CustomMqttTopicFilter());
+                ImmutableList.of(MqttTopicFilter.of("test"), mock(MqttTopicFilter.class));
 
         assertThrows(IllegalArgumentException.class, () -> Mqtt3Unsubscribe.builder().addTopicFilters(topicFilters));
     }