Skip to content

Commit fc5689d

Browse files
committed
Change method of encoding request URL
Switch to using `DefaultUriBuilderFactory` in Spring Boot 2 to encode the request URL, to fix a problem with "double encoding" of query parameters (see spring-projects/spring-framework#20750 (comment)).
1 parent 3879587 commit fc5689d

File tree

1 file changed

+0
-8
lines changed

1 file changed

+0
-8
lines changed

src/test/java/uk/gov/hmcts/ccd/data/user/DefaultUserRepositoryTest.java

-8
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,6 @@
33
import java.net.URI;
44
import java.util.Arrays;
55
import java.util.Collection;
6-
import java.util.Collections;
76
import java.util.Set;
87
import java.util.stream.Collectors;
98

@@ -31,7 +30,6 @@
3130
import org.junit.jupiter.api.DisplayName;
3231
import org.junit.jupiter.api.Nested;
3332
import org.junit.jupiter.api.Test;
34-
import org.mockito.ArgumentCaptor;
3533
import org.mockito.InjectMocks;
3634
import org.mockito.Mock;
3735
import org.mockito.MockitoAnnotations;
@@ -242,12 +240,6 @@ void shouldThrowExceptionIfErrorOnRetrievingUserProfile() {
242240
() -> userRepository.getUserDefaultSettings(userId),
243241
"Expected getUserDefaultSettings() to throw, but it didn't");
244242
assertThat(serviceException.getMessage(), is("Problem getting user default settings for " + userId));
245-
246-
// Check that the URL used in the request is encoded correctly, specifically the query string
247-
ArgumentCaptor<String> requestUrl = ArgumentCaptor.forClass(String.class);
248-
verify(restTemplate).exchange(
249-
requestUrl.capture(), same(HttpMethod.GET), any(HttpEntity.class), (Class<?>)any(Class.class));
250-
assertThat(requestUrl.getValue(), is("http://test.hmcts.net/users?uid=ccd%2Btest%40hmcts.net"));
251243
}
252244
}
253245

0 commit comments

Comments
 (0)