OCPBUGS-23514: status: Adjust impact summary for Failing=Unknown

[cvo#1165](openshift/cluster-version-operator#1165)
introduced uncertainty of the Failing condition (`Failing=Unknown`).
This PR adjusts the impact summary in updateInsight accordingly.

Author: hongkailiu

pkg/cli/admin/upgrade/status/controlplane.go

@@ -170,13 +170,17 @@ func assessControlPlaneStatus(cv *v1.ClusterVersion, operators []v1.ClusterOpera
 		}
 		insights = append(insights, insight)
 	} else if c.Status != v1.ConditionFalse {
+		verb := "is"
+		if c.Status == v1.ConditionUnknown {
+			verb = "may be"
+		}
 		insight := updateInsight{
 			startedAt: c.LastTransitionTime.Time,
 			scope:     updateInsightScope{scopeType: scopeTypeControlPlane, resources: []scopeResource{{kind: cvGroupKind, name: cv.Name}}},
 			impact: updateInsightImpact{
 				level:       warningImpactLevel,
 				impactType:  updateStalledImpactType,
-				summary:     fmt.Sprintf("Cluster Version %s is failing to proceed with the update (%s)", cv.Name, c.Reason),
+				summary:     fmt.Sprintf("Cluster Version %s %s failing to proceed with the update (%s)", cv.Name, verb, c.Reason),
 				description: c.Message,
 			},
 			remediation: updateInsightRemediation{reference: "https://github.com/openshift/runbooks/blob/master/alerts/cluster-monitoring-operator/ClusterOperatorDegraded.md"},

pkg/cli/admin/upgrade/status/controlplane_test.go

@@ -272,6 +272,74 @@ func TestAssessControlPlaneStatus_Operators(t *testing.T) {
 	}
 }
 
+func TestAssessControlPlaneStatus_insights(t *testing.T) {
+	testCases := []struct {
+		name     string
+		cv       *configv1.ClusterVersion
+		expected []updateInsight
+	}{
+		{
+			name: "cv: something went wrong",
+			cv: &configv1.ClusterVersion{
+				ObjectMeta: metav1.ObjectMeta{Name: "version"},
+				Status: configv1.ClusterVersionStatus{
+					Desired: configv1.Release{Version: "new"},
+					Conditions: []configv1.ClusterOperatorStatusCondition{{
+						Type:   clusterStatusFailing,
+						Status: configv1.ConditionTrue,
+						Reason: "something went wrong",
+					}},
+				},
+			},
+			expected: []updateInsight{
+				{
+					scope: updateInsightScope{scopeType: "ControlPlane", resources: []scopeResource{{kind: scopeGroupKind{group: "config.openshift.io", kind: "ClusterVersion"}, name: "version"}}},
+					impact: updateInsightImpact{
+						level:      warningImpactLevel,
+						impactType: "Update Stalled",
+						summary:    "Cluster Version version is failing to proceed with the update (something went wrong)",
+					},
+					remediation: updateInsightRemediation{reference: "https://github.com/openshift/runbooks/blob/master/alerts/cluster-monitoring-operator/ClusterOperatorDegraded.md"},
+				},
+			},
+		},
+		{
+			name: "cv: SlowClusterOperator",
+			cv: &configv1.ClusterVersion{
+				ObjectMeta: metav1.ObjectMeta{Name: "version"},
+				Status: configv1.ClusterVersionStatus{
+					Desired: configv1.Release{Version: "new"},
+					Conditions: []configv1.ClusterOperatorStatusCondition{{
+						Type:   clusterStatusFailing,
+						Status: configv1.ConditionUnknown,
+						Reason: "SlowClusterOperator",
+					}},
+				},
+			},
+			expected: []updateInsight{
+				{
+					scope: updateInsightScope{scopeType: "ControlPlane", resources: []scopeResource{{kind: scopeGroupKind{group: "config.openshift.io", kind: "ClusterVersion"}, name: "version"}}},
+					impact: updateInsightImpact{
+						level:      warningImpactLevel,
+						impactType: "Update Stalled",
+						summary:    "Cluster Version version may be failing to proceed with the update (SlowClusterOperator)",
+					},
+					remediation: updateInsightRemediation{reference: "https://github.com/openshift/runbooks/blob/master/alerts/cluster-monitoring-operator/ClusterOperatorDegraded.md"},
+				},
+			},
+		},
+	}
+
+	for _, tc := range testCases {
+		t.Run(tc.name, func(t *testing.T) {
+			_, insights := assessControlPlaneStatus(tc.cv, nil, "", time.Now())
+			if diff := cmp.Diff(tc.expected, insights, allowUnexportedInsightStructs); diff != "" {
+				t.Errorf("%s: expected insights differs from actual:\n%s", tc.name, diff)
+			}
+		})
+	}
+}
+
 func TestAssessControlPlaneStatus_Estimate(t *testing.T) {
 	now := time.Now()
 	minutesAgo := [250]time.Time{}