Skip to content

html-lang-require reports lots of false positives #653

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
coliff opened this issue Jun 11, 2021 · 4 comments · Fixed by #655
Closed

html-lang-require reports lots of false positives #653

coliff opened this issue Jun 11, 2021 · 4 comments · Fixed by #655

Comments

@coliff
Copy link
Member

coliff commented Jun 11, 2021 •
edited
Loading

Describe the bug

The html-lang-require rule appears to check every single tag when running

To Reproduce

Run htmlhint index.html with 0.15.0

Expected behavior

Only the <HTML> tag should be tested for this rule

Screenshots

Partial screenshot form terminal output:

image

cc @baleyko
@baleyko
Copy link
Contributor

baleyko commented Jun 11, 2021

@coliff I will make a fix today.

@baleyko baleyko mentioned this issue Jun 11, 2021
Merged
@baleyko
Copy link
Contributor

baleyko commented Jun 11, 2021

fixes are in this PR: #655

@thedaviddias
Copy link
Member

Thanks @coliff for logging the issue and @baleyko for fixing it so quickly! I believe we can close this ticket now as it was fixed in #655

@thedaviddias thedaviddias linked a pull request Jun 11, 2021 that will close this issue
fix: Unexpected behavior of the html lang require rule #655
Merged
@coliff
Copy link
Member Author

coliff commented Jun 11, 2021

Fixed now - thanks!

@coliff coliff closed this as completed Jun 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: Unexpected behavior of the html lang require rule baleyko/HTMLHint
3 participants
@thedaviddias @coliff @baleyko