Skip to content

Commit 49492a7

Browse files
committed
Extract duplicated logic to method
1 parent d3d7cc2 commit 49492a7

File tree

1 file changed

+13
-13
lines changed

1 file changed

+13
-13
lines changed

Diff for: lib/http-proxy/passes/web-outgoing.js

+13-13
Original file line numberDiff line numberDiff line change
@@ -83,32 +83,32 @@ module.exports = { // <--
8383
* @api private
8484
*/
8585
writeHeaders: function writeHeaders(req, res, proxyRes, options) {
86-
var rewriteCookieDomainConfig = options.cookieDomainRewrite;
86+
var rewriteCookieDomainConfig = options.cookieDomainRewrite,
87+
setHeader = function setHeader(key, header) {
88+
if (header != undefined) {
89+
if (rewriteCookieDomainConfig && key.toLowerCase() === 'set-cookie') {
90+
header = common.rewriteCookieDomain(header, rewriteCookieDomainConfig);
91+
}
92+
res.setHeader(String(key).trim(), header);
93+
}
94+
};
95+
8796
if (typeof rewriteCookieDomainConfig === 'string') { //also test for ''
8897
rewriteCookieDomainConfig = { '*': rewriteCookieDomainConfig };
8998
}
99+
90100
// message.rawHeaders is added in: v0.11.6
91101
// https://nodejs.org/api/http.html#http_message_rawheaders
92102
if (proxyRes.rawHeaders != undefined) {
93103
for (var i = 0; i < proxyRes.rawHeaders.length; i += 2) {
94104
var key = proxyRes.rawHeaders[i];
95105
var header = proxyRes.rawHeaders[i + 1];
96-
if (header != undefined) {
97-
if (rewriteCookieDomainConfig && key.toLowerCase() === 'set-cookie') {
98-
header = common.rewriteCookieDomain(header, rewriteCookieDomainConfig);
99-
}
100-
res.setHeader(String(key).trim(), header);
101-
}
106+
setHeader(key, header);
102107
};
103108
} else {
104109
Object.keys(proxyRes.headers).forEach(function(key) {
105110
var header = proxyRes.headers[key];
106-
if (header != undefined) {
107-
if (rewriteCookieDomainConfig && key.toLowerCase() === 'set-cookie') {
108-
header = common.rewriteCookieDomain(header, rewriteCookieDomainConfig);
109-
}
110-
res.setHeader(String(key).trim(), header);
111-
}
111+
setHeader(key, header);
112112
});
113113
}
114114
},

0 commit comments

Comments
 (0)