Skip to content

Commit 7bf0cae

Browse files
committed
[fix] Change variable references for Websockets, bugs found from using wsbench
1 parent 32a15dd commit 7bf0cae

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

Diff for: lib/node-http-proxy.js

+3-3
Original file line numberDiff line numberDiff line change
@@ -579,10 +579,10 @@ HttpProxy.prototype.proxyWebSocketRequest = function (req, socket, head, options
579579

580580
// Detach event listeners from reverseProxy
581581
function detach() {
582-
reverseProxy.removeListener('close', listeners._r_close);
582+
reverseProxy.removeListener('end', listeners._r_close);
583583
reverseProxy.removeListener('data', listeners._r_data);
584584
out.incoming.socket.removeListener('data', listeners._data);
585-
out.incoming.socket.removeListener('close', listeners._close);
585+
out.incoming.socket.removeListener('end', listeners._close);
586586
}
587587

588588
// Hook disconnections
@@ -591,7 +591,7 @@ HttpProxy.prototype.proxyWebSocketRequest = function (req, socket, head, options
591591
detach();
592592
});
593593

594-
socket.on('end', listeners._close = function() {
594+
out.incoming.socket.on('end', listeners._close = function() {
595595
reverseProxy.end();
596596
detach();
597597
});

0 commit comments

Comments
 (0)