Skip to content

Commit 7bf8d4a

Browse files
committed
[test] Add core test-http-client-abort test
Modifications: * make client connect to `PROXY_PORT` instead of `PORT` As off a95cf9b, this test doesn't hang.
1 parent 4d43d81 commit 7bf8d4a

File tree

1 file changed

+80
-0
lines changed

1 file changed

+80
-0
lines changed

Diff for: test/core/simple/test-http-client-abort.js

+80
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,80 @@
1+
// Copyright Joyent, Inc. and other Node contributors.
2+
//
3+
// Permission is hereby granted, free of charge, to any person obtaining a
4+
// copy of this software and associated documentation files (the
5+
// "Software"), to deal in the Software without restriction, including
6+
// without limitation the rights to use, copy, modify, merge, publish,
7+
// distribute, sublicense, and/or sell copies of the Software, and to permit
8+
// persons to whom the Software is furnished to do so, subject to the
9+
// following conditions:
10+
//
11+
// The above copyright notice and this permission notice shall be included
12+
// in all copies or substantial portions of the Software.
13+
//
14+
// THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS
15+
// OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF
16+
// MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN
17+
// NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM,
18+
// DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR
19+
// OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE
20+
// USE OR OTHER DEALINGS IN THE SOFTWARE.
21+
22+
var common = require('../common');
23+
var assert = require('assert');
24+
var http = require('http');
25+
26+
var clientAborts = 0;
27+
28+
var server = http.Server(function(req, res) {
29+
console.log('Got connection');
30+
res.writeHead(200);
31+
res.write('Working on it...');
32+
33+
// I would expect an error event from req or res that the client aborted
34+
// before completing the HTTP request / response cycle, or maybe a new
35+
// event like "aborted" or something.
36+
req.on('aborted', function() {
37+
clientAborts++;
38+
console.log('Got abort ' + clientAborts);
39+
if (clientAborts === N) {
40+
console.log('All aborts detected, you win.');
41+
server.close();
42+
}
43+
});
44+
45+
// since there is already clientError, maybe that would be appropriate,
46+
// since "error" is magical
47+
req.on('clientError', function() {
48+
console.log('Got clientError');
49+
});
50+
});
51+
52+
var responses = 0;
53+
var N = http.Agent.defaultMaxSockets - 1;
54+
var requests = [];
55+
56+
server.listen(common.PORT, function() {
57+
console.log('Server listening.');
58+
59+
for (var i = 0; i < N; i++) {
60+
console.log('Making client ' + i);
61+
var options = { port: common.PROXY_PORT, path: '/?id=' + i };
62+
var req = http.get(options, function(res) {
63+
console.log('Client response code ' + res.statusCode);
64+
65+
if (++responses == N) {
66+
console.log('All clients connected, destroying.');
67+
requests.forEach(function(outReq) {
68+
console.log('abort');
69+
outReq.abort();
70+
});
71+
}
72+
});
73+
74+
requests.push(req);
75+
}
76+
});
77+
78+
process.on('exit', function() {
79+
assert.equal(N, clientAborts);
80+
});

0 commit comments

Comments
 (0)