-
Notifications
You must be signed in to change notification settings - Fork 2k
Url corruption when ":/" present #946
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
@coderaiser its meant to handle cases where |
The thing is no args = [ '/', '/iocmd/join:/modules/format-io/lib/format.js:lib/client/directory.js:/join/join.js' ]
retSegs = [ '/iocmd/join://modules/format-io/lib/format.js:lib/client/directory.js://join/join.js' ] |
@coderaiser Yes I understand. I was mentioning thats why it exists, Im not saying its correct. The code here needs to be smarter to handle the case you are mentioning. |
Why are you replace lines:
:/
to://
in urlJoin of common.js?It corrupt work of join-io which uses such urls:
The text was updated successfully, but these errors were encountered: