-
Notifications
You must be signed in to change notification settings - Fork 5.9k
[New Pipeline]: UniControl for Unified Controllable Visual Generation #3788
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Thanks for opening this issue, @canqin001. The main components seem similar to ControlNet to me. Would you maybe be willing to contribute this as a pipeline to Diffusers? |
@sayakpaul Yes. We'd like to contribute this as a pipeline to diffusers. Could you provide more details on how to incorporate it into diffusers? Thank you! |
Sure! As a starting point, I think referring to the following documents will help you get some context:
And finally, the ControlNet PR would serve as a great reference for you: |
Exciting! |
This issue has been automatically marked as stale because it has not had recent activity. If you think this still needs to be addressed please comment on this thread. Please note that issues that do not follow the contributing guidelines are likely to be ignored. |
I think adding this model is still very much relevant - they have recently adding some new very cool checkpoints: https://github.com/salesforce/UniControl Anybody interested in picking this up? |
Thanks @patrickvonplaten. We really want to integrate UniControl to Diffuser. I just emailed @Abhinay1997 who will help us. Also my colleague @chiachihchen will participate. BTW, we have separated the inference code and released the HF space (https://huggingface.co/spaces/Robert001/UniControl-Demo). |
@patrickvonplaten @sayakpaul there are minor differences in the ControlNet for UniControl. We'll need to add a few layers ( for the task aware hypernet and the MOE adapter.). The approach is to modify the existing ControlNet while maintaining backward compatibility correct ? |
Yes that is correct. |
This issue has been automatically marked as stale because it has not had recent activity. If you think this still needs to be addressed please comment on this thread. Please note that issues that do not follow the contributing guidelines are likely to be ignored. |
Working on colab to port the weights and modify the controlnet. Expect lot of progress this week |
We have gotten the pipeline running end to end. There is a bug somewhere that results in gaussian noise as output. Similar to an issue I had with initial port of TuneAVideo where an op was incorrect. Hoping thats the case here. Once this is fixed. Will update the PR :) |
This issue has been automatically marked as stale because it has not had recent activity. If you think this still needs to be addressed please comment on this thread. Please note that issues that do not follow the contributing guidelines are likely to be ignored. |
Working poc in PR. Adding tests, batching, etc |
This issue has been automatically marked as stale because it has not had recent activity. If you think this still needs to be addressed please comment on this thread. Please note that issues that do not follow the contributing guidelines are likely to be ignored. |
PR is still being worked on. Tests pending. ETA this week |
Any updates? When will the unicontrol be available in diffusers? |
Model/Pipeline/Scheduler description
Github: https://github.com/salesforce/UniControl
Paper: https://arxiv.org/abs/2305.11147
Open source status
Provide useful links for the implementation
@canqin001 @yihaocs @shugerdou
The text was updated successfully, but these errors were encountered: