Skip to content

[New Pipeline]: UniControl for Unified Controllable Visual Generation #3788

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
2 tasks done
canqin001 opened this issue Jun 14, 2023 · 17 comments
Closed
2 tasks done
Labels
stale Issues that haven't received updates

Comments

@canqin001
Copy link

Model/Pipeline/Scheduler description

Github: https://github.com/salesforce/UniControl
Paper: https://arxiv.org/abs/2305.11147

Open source status

  • The model implementation is available
  • The model weights are available (Only relevant if addition is not a scheduler).

Provide useful links for the implementation

@canqin001 @yihaocs @shugerdou

@sayakpaul
Copy link
Member

Thanks for opening this issue, @canqin001. The main components seem similar to ControlNet to me.

Would you maybe be willing to contribute this as a pipeline to Diffusers?

@canqin001
Copy link
Author

@sayakpaul Yes. We'd like to contribute this as a pipeline to diffusers. Could you provide more details on how to incorporate it into diffusers? Thank you!

@sayakpaul
Copy link
Member

Sure!

As a starting point, I think referring to the following documents will help you get some context:

And finally, the ControlNet PR would serve as a great reference for you:
#2407 (contributed by the awesome @takuma104).

@patrickvonplaten
Copy link
Contributor

Exciting!

@github-actions
Copy link
Contributor

This issue has been automatically marked as stale because it has not had recent activity. If you think this still needs to be addressed please comment on this thread.

Please note that issues that do not follow the contributing guidelines are likely to be ignored.

@github-actions github-actions bot added the stale Issues that haven't received updates label Jul 15, 2023
@patrickvonplaten patrickvonplaten removed the stale Issues that haven't received updates label Jul 24, 2023
@patrickvonplaten
Copy link
Contributor

I think adding this model is still very much relevant - they have recently adding some new very cool checkpoints: https://github.com/salesforce/UniControl

Anybody interested in picking this up?

@canqin001
Copy link
Author

Thanks @patrickvonplaten. We really want to integrate UniControl to Diffuser. I just emailed @Abhinay1997 who will help us. Also my colleague @chiachihchen will participate. BTW, we have separated the inference code and released the HF space (https://huggingface.co/spaces/Robert001/UniControl-Demo).

@Abhinay1997
Copy link
Contributor

@patrickvonplaten @sayakpaul there are minor differences in the ControlNet for UniControl. We'll need to add a few layers ( for the task aware hypernet and the MOE adapter.). The approach is to modify the existing ControlNet while maintaining backward compatibility correct ?

@sayakpaul
Copy link
Member

Yes that is correct.

@github-actions
Copy link
Contributor

This issue has been automatically marked as stale because it has not had recent activity. If you think this still needs to be addressed please comment on this thread.

Please note that issues that do not follow the contributing guidelines are likely to be ignored.

@github-actions github-actions bot added the stale Issues that haven't received updates label Aug 27, 2023
@Abhinay1997
Copy link
Contributor

Working on colab to port the weights and modify the controlnet. Expect lot of progress this week

@Abhinay1997
Copy link
Contributor

We have gotten the pipeline running end to end. There is a bug somewhere that results in gaussian noise as output. Similar to an issue I had with initial port of TuneAVideo where an op was incorrect. Hoping thats the case here. Once this is fixed. Will update the PR :)

@github-actions
Copy link
Contributor

This issue has been automatically marked as stale because it has not had recent activity. If you think this still needs to be addressed please comment on this thread.

Please note that issues that do not follow the contributing guidelines are likely to be ignored.

@Abhinay1997
Copy link
Contributor

Working poc in PR. Adding tests, batching, etc

Copy link
Contributor

This issue has been automatically marked as stale because it has not had recent activity. If you think this still needs to be addressed please comment on this thread.

Please note that issues that do not follow the contributing guidelines are likely to be ignored.

@Abhinay1997
Copy link
Contributor

PR is still being worked on. Tests pending. ETA this week

@Sierkinhane
Copy link

Any updates? When will the unicontrol be available in diffusers?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stale Issues that haven't received updates
Projects
None yet
Development

No branches or pull requests

5 participants