Skip to content

Update _convert_kohya_ss_state_dict to directly output the new naming conventions #4268

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
williamberman opened this issue Jul 25, 2023 · 7 comments
Labels
good first issue Good for newcomers

Comments

@williamberman
Copy link
Contributor

_convert_kohya_ss_state_dict outputs the legacy lora conventions when the additional layer was stored on the model without a formal separate module. We should update it to directly output the new naming convention with formal lora layers

See previous discussion: #4147 (comment)

@williamberman williamberman added the good first issue Good for newcomers label Jul 25, 2023
@hackpk
Copy link

hackpk commented Aug 14, 2023

@williamberman Can I work on this??

@williamberman
Copy link
Contributor Author

sure :)

@hackpk
Copy link

hackpk commented Aug 16, 2023

@williamberman Thanks I will be needing some help. I checked the discussion but couldn't understand much. Can you please tell me where to start ??

@Lorenzobattistela
Copy link

@williamberman I'd like to work on this. I checked the discussion and I do understand that we need to update output to new naming conventions. Where can i find these conventions? Thanks in advance

@amk16
Copy link

amk16 commented Dec 20, 2023

Hey is anyone working on this otherwise could I?

@AbhinavJangra29
Copy link

is anyone working on this ?

@sayakpaul
Copy link
Member

It's done already. So, closing this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

6 participants