Skip to content

Documentation about superresolution #9566

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
christopher5106 opened this issue Oct 1, 2024 · 7 comments · Fixed by #10704
Closed

Documentation about superresolution #9566

christopher5106 opened this issue Oct 1, 2024 · 7 comments · Fixed by #10704
Assignees
Labels
bug Something isn't working

Comments

@christopher5106
Copy link

Describe the bug

Reading this documentation which is not possible.
Indeed, super resolution pipeline works with an image as input in the image input parameter.
So it's not possible to use output_type="latent" for image_2.
Otherwise you'll get an error :
ValueError: Incorrect configuration settings! The config of pipeline.unet expects 7 but received num_channels_latents: 4 + num_channels_image: 4 = 8. Please verify the config of pipeline.unet or your image input.
Because it's placing a latent instead of an image.

Please also note that "variant="fp16" does not work for stabilityai/sd-x2-latent-upscaler" for me. The error message I get is :

ValueError: The deprecation tuple ('no variant default', '0.24.0', "You are trying to load the model files of the `variant=fp16`, but no such modeling files are available.The default model files: {'unet/diffusion_pytorch_model.bin', 'text_encoder/pytorch_model.bin', 'text_encoder/model.safetensors', 'vae/diffusion_pytorch_model.safetensors', 'vae/diffusion_pytorch_model.bin', 'unet/diffusion_pytorch_model.safetensors'} will be loaded instead. Make sure to not load from `variant=fp16`if such variant modeling files are not available. Doing so will lead to an error in v0.24.0 as defaulting to non-variantmodeling files is deprecated.") should be removed since diffusers' version 0.30.3 is >= 0.24.0

Reproduction

simple snippet of code

Logs

No response

System Info

ubuntu

Who can help?

@yiyixuxu @asomoza

@christopher5106 christopher5106 added the bug Something isn't working label Oct 1, 2024
@asomoza
Copy link
Member

asomoza commented Oct 2, 2024

Hi, thanks for reporting, since you found the errors, are you interested in opening a PR to fix it?

cc @stevhliu

@christopher5106
Copy link
Author

The process of PR is a bit heavy. I have to do it with a fork. But I already have a fork that I use for something else, I commited on the main branch of my fork... Github doesn't allow me to create multiple fork, or to create PR from something else than a fork. Sorry

Copy link
Contributor

github-actions bot commented Nov 1, 2024

This issue has been automatically marked as stale because it has not had recent activity. If you think this still needs to be addressed please comment on this thread.

Please note that issues that do not follow the contributing guidelines are likely to be ignored.

@github-actions github-actions bot added the stale Issues that haven't received updates label Nov 1, 2024
@stevhliu stevhliu removed the stale Issues that haven't received updates label Nov 1, 2024
Copy link
Contributor

This issue has been automatically marked as stale because it has not had recent activity. If you think this still needs to be addressed please comment on this thread.

Please note that issues that do not follow the contributing guidelines are likely to be ignored.

@github-actions github-actions bot added the stale Issues that haven't received updates label Nov 26, 2024
@stevhliu stevhliu removed the stale Issues that haven't received updates label Nov 26, 2024
@asomoza asomoza self-assigned this Nov 26, 2024
Copy link
Contributor

This issue has been automatically marked as stale because it has not had recent activity. If you think this still needs to be addressed please comment on this thread.

Please note that issues that do not follow the contributing guidelines are likely to be ignored.

@github-actions github-actions bot added the stale Issues that haven't received updates label Dec 21, 2024
@ParagEkbote
Copy link
Contributor

Can I please contribute to this issue?

cc: @asomoza

@github-actions github-actions bot removed the stale Issues that haven't received updates label Jan 12, 2025
@stevhliu
Copy link
Member

Feel free to take this up! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants